Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update wiki-editor.js #26

Merged
merged 2 commits into from
Apr 3, 2022
Merged

feat: Update wiki-editor.js #26

merged 2 commits into from
Apr 3, 2022

Conversation

bhsd-harry
Copy link
Member

  1. Remove an enormous amount of redundant code.

  2. Add more powerful tools to the toolbar, depending on the site MW version.

  3. Correctly bind context to dialogs when they are opened.

1. Remove an enormous amount of redundant code.

2. Add more powerful tools to the toolbar, depending on the site MW version.

3. Correctly bind context to dialogs when they are opened.
@lgtm-com
Copy link

lgtm-com bot commented Mar 15, 2022

This pull request fixes 2 alerts when merging 5945536 into 0c4f367 - view on LGTM.com

fixed alerts:

  • 2 for Useless conditional

@bhsd-harry
Copy link
Member Author

This is part of inpageedit/inpageedit-v2#183.

@lgtm-com
Copy link

lgtm-com bot commented Mar 20, 2022

This pull request fixes 2 alerts when merging 1d60e1f into 0c4f367 - view on LGTM.com

fixed alerts:

  • 2 for Useless conditional

Copy link
Member

@dragon-fish dragon-fish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Great job

@bhsd-harry bhsd-harry merged commit 6baec31 into master Apr 3, 2022
@bhsd-harry bhsd-harry deleted the wiki-editor branch April 3, 2022 14:35
@dragon-fish dragon-fish restored the wiki-editor branch April 3, 2022 14:42
@dragon-fish dragon-fish deleted the wiki-editor branch May 19, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants