-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added cat-data-service-client | NPG-6476 #449
Conversation
Is all this code (or the majority) autogenerated? |
Yes it is all autogenerated from the openapi spec with https://openapi-generator.tech/docs/generators/rust/ |
In general its not a good idea to put autogenerated code/data into git, because it will/should change every time we update the ap[I yaml file. It would be better if this was just the scripting to run the generator, and then .gitignore files for the resulting generated data. |
I absolutely agree on that, in general. |
What exactly do we need to make changes in autogenerated code? That sounds like we probably doing something wrong. |
The code is generated with a couple of compilation errors that I fix manually (I suspect they are there due to the openapi spec not being 100% correct but still valid) |
@nicopado should we close this one? |
No description provided.