Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: IdeaScale importer no longer one exception for each worker when fetching stage ideas | NPG-6949 #468

Conversation

FelipeRosa
Copy link
Contributor

@FelipeRosa FelipeRosa commented Jul 7, 2023

  • Fixed the issue with ideascale.Client.stage_ideas throwing 1 stage not found exception for each download task worker (now it throws only 1)

@FelipeRosa FelipeRosa self-assigned this Jul 7, 2023
@FelipeRosa FelipeRosa requested a review from kukkok3 July 7, 2023 20:06
@FelipeRosa FelipeRosa changed the title fix: IdeaScale importer no longer one exception for each worker when fetching stage ideas fix: IdeaScale importer no longer one exception for each worker when fetching stage ideas | NPG-6949 Jul 7, 2023
@minikin minikin enabled auto-merge (squash) July 9, 2023 18:21
@minikin minikin added the review me PR is ready for review label Jul 10, 2023
@minikin
Copy link
Collaborator

minikin commented Jul 11, 2023

@kukkok3 Can you have a look, please?

Copy link
Contributor

@kukkok3 kukkok3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see this
2023-07-12T17:10:46.812458+0200 ERROR Get request failed status=404 content={"apiToken":"8bf71053-8437-400c-bd9c-45653796a999","apiVersion":"v1","cause":"","memberName":"stefano.cunego cunego","communityName":"Temporary Cardano Sandbox","requestUri":"/a/rest/v1/stages/138/ideas/9/50","communityId":170,"message":"Stage not found","key":"STAGE_NOT_FOUND","memberId":189900}

Cant we have a nice error like for the campaigns?:)

2023-07-12T17:11:18.527520+0200 ERROR Campaign group id does not correspond to any fund campaign group id

@FelipeRosa FelipeRosa force-pushed the NPG-6949-ideascale-importer-not-existent-stage-id-throws-exception branch from 8d5eef1 to 41e4add Compare July 13, 2023 15:42
@FelipeRosa FelipeRosa requested a review from kukkok3 July 13, 2023 15:42
Copy link
Contributor

@kukkok3 kukkok3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minikin minikin merged commit 8a90b8c into main Jul 17, 2023
25 checks passed
@minikin minikin deleted the NPG-6949-ideascale-importer-not-existent-stage-id-throws-exception branch July 17, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants