Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cat-voices): language code component #1730

Merged
merged 14 commits into from
Jan 30, 2025
Merged

feat(cat-voices): language code component #1730

merged 14 commits into from
Jan 30, 2025

Conversation

LynxLynxx
Copy link
Contributor

Description

Creates language code component to select languages.

Me and @minikin that for now we ignore exotic missing languages

Related Issue(s)

Closes #1657

Screenshots

Nagranie.z.ekranu.2025-01-29.o.15.54.20.mov

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@LynxLynxx LynxLynxx added review me PR is ready for review ux/ui UX/UI related issues F14 labels Jan 29, 2025
@LynxLynxx LynxLynxx added this to the Fund14 Technical Readiness milestone Jan 29, 2025
@LynxLynxx LynxLynxx self-assigned this Jan 29, 2025
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 449/449}$ | ${\color{red}Fail: 0/449}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 449/449}$ | ${\color{red}Fail: 0/449}$ |

LynxLynxx and others added 2 commits January 30, 2025 09:34
@LynxLynxx
feat: filter out null dropdown menu entries
3aa284e 
* Filter out null values when creating dropdown menu entries in `LanguageCodeWidget`.
* Remove unnecessary setState call in `didChangeDependencies`.
@LynxLynxx
Merge branch 'main' into feat/1657-language-code-component
97fab53
@LynxLynxx
refactor: update language code widget
b9098c3 
- Refactor: Renamed `handleInitialValue` to `_handleInitialValue`.
- Refactor: Renamed `handleValueChanged` to `_handleValueChanged`.
- Refactor: Renamed `notifyChangeListener` to `_notifyChangeListener`.
- Refactor: Renamed `getLocalizedLanguageName` to `_getLocalizedLanguageName`.
@LynxLynxx LynxLynxx enabled auto-merge (squash) January 30, 2025 09:01
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 449/449}$ | ${\color{red}Fail: 0/449}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 449/449}$ | ${\color{red}Fail: 0/449}$ |

@LynxLynxx LynxLynxx merged commit 9eeb0df into main Jan 30, 2025
38 checks passed
@LynxLynxx LynxLynxx deleted the feat/1657-language-code-component branch January 30, 2025 09:33
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 449/449}$ | ${\color{red}Fail: 0/449}$ |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtscalac dtscalac dtscalac approved these changes

@damian-molinski damian-molinski Awaiting requested review from damian-molinski damian-molinski is a code owner

Assignees

@LynxLynxx LynxLynxx

Labels
F14 review me PR is ready for review ux/ui UX/UI related issues
Projects
Catalyst
Archived in project
Milestone
Fund14 Technical Readiness
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : User Input Component - Language code
2 participants
@LynxLynxx @dtscalac