chain-impl-mockchain: use more idiomatic builder-style APIs #533
Open
eugene-babichenko wants to merge 1 commit intomasterfrom
Open
chain-impl-mockchain: use more idiomatic builder-style APIs #533eugene-babichenko wants to merge 1 commit intomasterfrom
eugene-babichenko wants to merge 1 commit intomasterfrom
Conversation
eugene-babichenko
force-pushed
the
improve-testing-apis
branch
from
41d87f7 to
b8198da
Compare
eugene-babichenko
changed the title
mzabaluev
approved these changes
Feb 26, 2021
mzabaluev
reviewed
Jul 13, 2021
|
|
||
| fn verify_distribute_rewards( | ||
| total_reward: u64, | ||
| stake_pool_builder: &mut StakePoolDefBuilder, |
Contributor
There was a problem hiding this comment.
OK, this was clearly wrong...
| self.with_date(parent.block_date()); | ||
| self.with_chain_length(parent.chain_length()); | ||
| self | ||
| pub fn with_parent(self, parent: &Header) -> Self { |
Contributor
There was a problem hiding this comment.
Can you describe the benefits of changing this? Both styles have their own advantages.
eugene-babichenko
force-pushed
the
improve-testing-apis
branch
from
b8198da to
40fa6ea
Compare
eugene-babichenko
force-pushed
the
improve-testing-apis
branch
from
40fa6ea to
26085d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.