Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce size of proving keys and verifying keys #6

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

miguel-ambrona
Copy link

@miguel-ambrona miguel-ambrona commented Apr 24, 2024

For proving keys, on "write" we skip some information which we can easily recompute on "read".

For verifying keys, we disable the complex selector flag globally.

@miguel-ambrona miguel-ambrona force-pushed the ambrona@smaller-vk branch 2 times, most recently from c776b25 to 3169faa Compare April 24, 2024 16:00
@miguel-ambrona miguel-ambrona changed the title Reduce size of verifying keys Reduce size of proving keys and verifying keys Apr 26, 2024
@iquerejeta iquerejeta self-requested a review April 26, 2024 15:28
Copy link
Collaborator

@iquerejeta iquerejeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - is there an issue or a fix for this in the PSE fork? If yes, could we link it in this PR please?

@miguel-ambrona
Copy link
Author

LGTM - is there an issue or a fix for this in the PSE fork? If yes, could we link it in this PR please?

No, because I think this is more an internal Midnight need.

@miguel-ambrona miguel-ambrona merged commit 0bcf414 into fixed_73408a1 Apr 26, 2024
15 checks passed
iquerejeta added a commit that referenced this pull request May 8, 2024
iquerejeta added a commit that referenced this pull request May 8, 2024
* plonk/keygen: add function to compute l polys

* plonk/permutation/keygen: add function to compute polys and cosets

* plonk: improve size of serialized prover keys

Co-authored-by: Iñigo Querejeta Azurmendi <31273774+iquerejeta@users.noreply.github.com>

* plonk/keygen: disable complex selectors

---------

Co-authored-by: Iñigo Querejeta Azurmendi <31273774+iquerejeta@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants