Skip to content

Conversation

iccicci
Copy link
Contributor

@iccicci iccicci commented Sep 29, 2025

Checklist

  • JIRA - LW-13590
  • Proper tests implemented
  • Screenshots added.

Proposed solution

Adds the Notifications Center component

@iccicci iccicci requested a review from a team as a code owner September 29, 2025 07:32
Copy link

@lace-bot
Copy link
Collaborator

lace-bot commented Sep 29, 2025

Allure Report

allure-report-publisher generated test report!

processReports: ✅ test report for bf82d177

passed failed skipped flaky total result
Total 33 0 4 0 37

}

.sectionTitle {
margin-bottom: size_unit(5.5);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is margin specific properties available on Flex component
mb={$44}

@import '../../../../../packages/core/src/ui/styles/theme.scss';
@import '../../../../../packages/common/src/ui/styles/theme.scss';

.markAllAsRead {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kindly rename to be something more generic, eg: button, otherwise, if copy of this component changes, you'll need to rename class as well*

margin-bottom: size_unit(5.5);

.title {
margin-bottom: 0px !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

const history = useHistory();
const { walletUI } = useWalletStore();

if (!posthog?.isFeatureFlagEnabled(ExperimentName.NOTIFICATIONS_CENTER)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could render this route conditionally in apps/browser-extension-wallet/src/routes/ExtensionRoutes.tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants