-
Notifications
You must be signed in to change notification settings - Fork 13
LW-13590 Add the notifications center #2001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Allure Report
processReports: ✅ test report for bf82d177
|
} | ||
|
||
.sectionTitle { | ||
margin-bottom: size_unit(5.5); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is margin specific properties available on Flex component
mb={$44}
@import '../../../../../packages/core/src/ui/styles/theme.scss'; | ||
@import '../../../../../packages/common/src/ui/styles/theme.scss'; | ||
|
||
.markAllAsRead { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kindly rename to be something more generic, eg: button
, otherwise, if copy of this component changes, you'll need to rename class as well*
margin-bottom: size_unit(5.5); | ||
|
||
.title { | ||
margin-bottom: 0px !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
const history = useHistory(); | ||
const { walletUI } = useWalletStore(); | ||
|
||
if (!posthog?.isFeatureFlagEnabled(ExperimentName.NOTIFICATIONS_CENTER)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could render this route conditionally in apps/browser-extension-wallet/src/routes/ExtensionRoutes.tsx
Checklist
Proposed solution
Adds the Notifications Center component