Conway HF update (cardano-node 8.9.0) #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhenin
force-pushed
the
nhenin/sanchonet
branch
from
f84e1da
to
5d5b5e5
Compare
nhenin
force-pushed
the
nhenin/sanchonet
branch
from
cec53c7
to
c323d14
Compare
nhenin
force-pushed
the
nhenin/sanchonet
branch
2 times, most recently
from
035b21c
to
ab8f22e
Compare
nhenin
force-pushed
the
nhenin/sanchonet
branch
from
c87a911
to
ebbdccb
Compare
nhenin
force-pushed
the
nhenin/sanchonet
branch
5 times, most recently
from
31357fa
to
ba9fdf9
Compare
zeme-wana
force-pushed
the
nhenin/sanchonet
branch
2 times, most recently
from
9b29bc5
to
e941cfc
Compare
nhenin
force-pushed
the
nhenin/sanchonet
branch
2 times, most recently
from
579affc
to
45be3e6
Compare
nhenin
force-pushed
the
nhenin/sanchonet
branch
from
45be3e6
to
d6188fc
Compare
nhenin
commented
Mar 20, 2024
| @@ -729,7 +729,7 @@ whenNonEmptySpec = parallel $ describe "Non-Empty When contracts" $ aroundAll se | |||
| emptyMarloweTransactionMetadata | |||
| [NormalInput $ IDeposit address address ada 1_000_000] | |||
| SubmitFailed msg <- expectLeft "Expected a failure" =<< submit' wallet era txBody | |||
| liftIO $ msg `shouldContain` "MissingRequiredSigners" | |||
| liftIO $ msg `shouldContain` "MissingVKeyWitnessesUTXOW" | |||
| it "should accept a Role2 deposit from wallet 2" $ runAsIntegration \(ContractCreated _ ContractCreatedInEra{..}) -> do | |||
There was a problem hiding this comment.
MissingRequiredSigners doesn't exist anymore (because it is redundant with MissingVKeyWitnessesUTXOW) and some tests were expecting this particular exception :
- https://github.com/IntersectMBO/cardano-ledger/blob/0e115dd5a38484da1ac2d72559aff8579b887970/eras/alonzo/impl/src/Cardano/Ledger/Alonzo/Rules/Utxow.hs#L118
- IntersectMBO/cardano-ledger#3972
bwbush
reviewed
Mar 21, 2024
| @@ -345,7 +346,7 @@ protocolTestnet = | |||
| , protocolParamStakeAddressDeposit = C.Lovelace 2000000 | |||
| , protocolParamStakePoolDeposit = C.Lovelace 500000000 | |||
| , protocolParamMinPoolCost = C.Lovelace 340000000 | |||
| , protocolParamPoolRetireMaxEpoch = C.EpochNo 18 | |||
| , protocolParamPoolRetireMaxEpoch = CI.EpochInterval 18 | |||
There was a problem hiding this comment.
All of these parameters should be upgraded to Conway sometime before the hard fork.
bwbush
reviewed
Mar 21, 2024
| @@ -1772,13 +1773,12 @@ protocolTestnet = | |||
| , protocolParamStakeAddressDeposit = Lovelace 2000000 | |||
| , protocolParamStakePoolDeposit = Lovelace 500000000 | |||
| , protocolParamMinPoolCost = Lovelace 340000000 | |||
| , protocolParamPoolRetireMaxEpoch = EpochNo 18 | |||
| , protocolParamPoolRetireMaxEpoch = EpochInterval 18 | |||
There was a problem hiding this comment.
Upgrade all of these to Conway values before the hard fork.
bwbush
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.