-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance logs in client and client-cli #2013
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alenar
force-pushed
the
djo/1981/enhance_logs_in_client
branch
from
October 17, 2024 10:28
99ee776
to
d5119f4
Compare
Base automatically changed from
djo/refactor_client_cli_command_params
to
main
October 17, 2024 10:40
* Move away from main log message to a property huge structure * Reduce space taken by some logs when possible
* Tagged with the component name.
Use full path instead of needing a use gated by an `cfg(test)` that add noises with the other imports.
Instead of the default `slog-rs`.
* Move away from main log message to a property huge structure * Reduce space taken by some logs when possible
Alenar
force-pushed
the
djo/1981/enhance_logs_in_client
branch
from
October 17, 2024 10:49
d5119f4
to
808ae15
Compare
dlachaume
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
jpraynaud
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
* mithril-client-cli from `0.9.16` to `0.9.17` * mithril-client from `0.9.2` to `0.9.3`
Alenar
temporarily deployed
to
testing-preview
October 17, 2024 15:05
— with
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
October 17, 2024 15:05
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR refactor the log usage in
mithril-client
andmithril-client-cli
:mithril-client
)slog-rs
tomithril-client
(onlymithril-client-cli
).slog_scope
to enforce the usage of a name tagged child logger.Pre-submit checklist
Issue(s)
Relates to #1981