-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove beacon from certificate #2055
Conversation
As it was only needed as a "poor man" source of immutable file number for certificate when the signed entity type was not CardanoImmutableFilesFull.
Test Results 4 files ±0 51 suites ±0 10m 41s ⏱️ +15s Results for commit 22dc14f. ± Comparison against base commit 650e77d. This pull request removes 4 and adds 2 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
…ficate list routes
9b841f4
to
ef31341
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e9a0655
to
f2a48f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
* mithril-aggregator from `0.5.91` to `0.5.92` * mithril-client from `0.9.4` to `0.10.0` * mithril-client-cli from `0.9.18` to `0.10.0` * mithril-client-wasm from `0.5.3` to `0.6.0` * mithril-common from `0.4.75` to `0.4.76` * mithril-aggregator-fake from `0.3.10` to `0.3.11` * openapi.yaml from `0.1.32` to `0.1.33`
f2a48f4
to
22dc14f
Compare
Content
This PR remove the
beacon
field from theCertificateMessage
andCertificateListMessage
as this field was supersede by thesigned_entity_type
field, field that is mandatory since distribution2418.1
.This allow to remove the
immutable_file_number
plus the conversion to cardano db beacon on theCertificateMetadata
entity and theCertificateRecord
, those only existed to recover the beacon when building a message.Warning
Nodes from distribution below
2430
are not compatible with this change.Pre-submit checklist
Comments
This changes should not induce a recompute of the certificates hashes as the immutable file number was not used in the certificate hash computation (the epoch and the network are still used).
Issue(s)
Closes #1958