Remove beacon from certificate #2055
Merged
+1,872
−5,623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it was only needed as a "poor man" source of immutable file number for certificate when the signed entity type was not CardanoImmutableFilesFull.
Test Results 4 files ±0 51 suites ±0 10m 41s ⏱️ +15s Results for commit 22dc14f. ± Comparison against base commit 650e77d. This pull request removes 4 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
…ficate list routes
Alenar
force-pushed
the
djo/1958/remove_beacon_from_certificate
branch
from
9b841f4
to
ef31341
Compare
Alenar
force-pushed
the
djo/1958/remove_beacon_from_certificate
branch
from
e9a0655
to
f2a48f4
Compare
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
* mithril-aggregator from `0.5.91` to `0.5.92` * mithril-client from `0.9.4` to `0.10.0` * mithril-client-cli from `0.9.18` to `0.10.0` * mithril-client-wasm from `0.5.3` to `0.6.0` * mithril-common from `0.4.75` to `0.4.76` * mithril-aggregator-fake from `0.3.10` to `0.3.11` * openapi.yaml from `0.1.32` to `0.1.33`
Alenar
force-pushed
the
djo/1958/remove_beacon_from_certificate
branch
from
f2a48f4
to
22dc14f
Compare
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR remove the
beaconfield from theCertificateMessageandCertificateListMessageas this field was supersede by thesigned_entity_typefield, field that is mandatory since distribution2418.1.This allow to remove the
immutable_file_numberplus the conversion to cardano db beacon on theCertificateMetadataentity and theCertificateRecord, those only existed to recover the beacon when building a message.Warning
Nodes from distribution below
2430are not compatible with this change.Pre-submit checklist
Comments
This changes should not induce a recompute of the certificates hashes as the immutable file number was not used in the certificate hash computation (the epoch and the network are still used).
Issue(s)
Closes #1958