address associations pallet - demo #185
Conversation
AmbientTea
force-pushed
the
ETCM-8697-address-association-pallet-demo
branch
from
abf1379
to
071a64f
Compare
| } | ||
|
|
||
| /// Retrieves all main chain - partner chain address associations from the runtime storage. | ||
| pub fn get_all_address_associations() -> Vec<(T::MainChainAddress, T::PartnerChainAddress)> |
There was a problem hiding this comment.
Are they unbounded? I think pallet has to have it configured and at some point defined behaivor when too many associations are made.
There was a problem hiding this comment.
In principle they are. As Midnight or any other chain grows, there will be more and more associations. Also, there's no de-association, so they stay forever. Perhaps this function won't be needed at all, or we could return impl Iterator.
| #[pallet::config] | ||
| pub trait Config: frame_system::Config { | ||
| /// Main chain address type | ||
| type MainChainAddress: Member + Parameter + MaxEncodedLen; |
| type MainChainAddress: Member + Parameter + MaxEncodedLen; | ||
|
|
||
| /// Partner chain address type | ||
| type PartnerChainAddress: Member + Parameter + MaxEncodedLen; |
There was a problem hiding this comment.
I would make it a Value and make the pallet cardano-associations. I don't even know if cardano is important part here.
There was a problem hiding this comment.
I don't think Cardano is important here, but having a key-pair-pallet would be too general. I'd like to stay within the domain "associating some main chain identifier with some partner chain identifier", whatever chain the main chain and partner chain happen to be.
Description
This is a demo of the client-facing API of the address associations pallet.