-
-
Notifications
You must be signed in to change notification settings - Fork 777
Update Project Settings for Contributors #750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Removing this can prevent Xcode from modifying "$(inherited)" to derived team ID when users select the signing tab, to avoid unintended changes.
COPY_PHASE_STRIP = NO; | ||
DEAD_CODE_STRIPPING = YES; | ||
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym"; | ||
DEVELOPMENT_TEAM = 72X6ZPCY5L; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had previously set these to $(inherited) because Xcode kept trying to copy the value from the config into this file whenever you change a build setting through the UI. At least I’m pretty sure that got merged in.
Did Xcode overwrite $(inherited) or was there a conflict resolution where you took your side?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, it looks like this was actually my fault! Gonna check on that more today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had previously set these to $(inherited) because Xcode kept trying to copy the value from the config into this file whenever you change a build setting through the UI. At least I’m pretty sure that got merged in.
Did Xcode overwrite $(inherited) or was there a conflict resolution where you took your side?
Yeah, I tried using $(inherited), but once I opened the signing tab, and switched to the repo, actual id was overwritten
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😞 That's very frustrating! I’ve had this problems with other settings in xcconfig files before, too. I should probably take that time to create a sample project and open a Feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😞 That's very frustrating! I’ve had this problems with other settings in xcconfig files before, too. I should probably take that time to create a sample project and open a Feedback.
I think it's been like this for a long time, almost every project I cloned has last team id embedded😅
@allenhumphreys This pr indeed does not fix the issue. It seems to me that a pattern exists here. As long as you don’t open WWDC under PROJECT settings, no new changes will be added. But another project using Xcode configuration to distinguish bundle id doesn't have this behaviour, which is very strange.🥲 Screen.Recording.2025-09-11.at.17.13.53.mp4 |
Yes, this particular setting ( A potential solution/workaround/defensive measure I thought of was to add a build phase script that removes these lines using sed. I don't know if writing the pbxproj file during a build will cause a major problems though. |
Also wow, good job figuring out exactly the scenario in which it does it. It doesn't do it if you open target settings. Or even signing settings in the target, but as soon as you open the project level settings it overwrites it! |
A working sed script/command Xcode is 100% doing the wrong thing though. |
Adding the script in the build phase, I think, can't avoid developers committing this change, but git hooks will warn them. Screen.Recording.2025-09-12.at.11.05.06.mp4 |
647ca95 accidentally committed a different TeamID, resulting in Xcode not reading the team id from the Xcode configuration, so:
Remove DEVELOPMENT_TEAM from xcodeproj
Update Package.resolved for ConfCore, by the way, for 8f31557