-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support pagination of lists of rtables/rlistings objects #213
Conversation
Code Coverage Summary
Diff against main
Results for commit: 25396b0 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 5 suites 13s ⏱️ Results for commit 25396b0. ♻️ This comment has been updated with latest results. |
@Melkiades I have a rough solution here that is working for lists of listings (haven't tested lists of tables yet). Feel free to test and make any changes as you see fit! You can also modify insightsengineering/rlistings#166 if you'd like which is also working (in combination with this PR) to paginate by parameter. EDIT: Full solution is now uploaded. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm @Melkiades! Just a few suggestions to clarify the warnings.
Co-authored-by: Emily de la Rua <59304861+edelarua@users.noreply.github.com> Signed-off-by: Davide Garolini <dgarolini@gmail.com>
…ering/formatters into 212_page_by_listings@main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is looking good as well! :)
Closes #212