Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace logo.png by logo.svg #330

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Replace logo.png by logo.svg #330

merged 2 commits into from
Dec 18, 2024

Conversation

llrs-roche
Copy link
Contributor

Pull Request

Replace the logo.png by logo.svg to reduce much more than the previous compressions of png on #329: (500Kb -> 70Kb) and it is vectorized to allow for any resolution.

Fixes insightsengineering/nestdevs-tasks#93

Copy link
Contributor

github-actions bot commented Dec 18, 2024

Unit Tests Summary

  1 files    8 suites   15s ⏱️
 54 tests  54 ✅ 0 💤 0 ❌
372 runs  372 ✅ 0 💤 0 ❌

Results for commit 395145b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

badge

Code Coverage Summary

Filename             Stmts    Miss  Cover    Missing
-----------------  -------  ------  -------  -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/format_value.R       197      12  93.91%   88, 105-112, 187, 204, 409, 423, 431
R/generics.R           125      12  90.40%   142, 280-284, 486, 498, 529, 559, 667, 680, 701-708
R/labels.R              55       7  87.27%   51, 57, 66, 107, 133, 142, 146
R/matrix_form.R        691      41  94.07%   131, 392, 512-513, 605, 615-618, 636, 667, 757-758, 772-777, 807-810, 870-871, 960-961, 988, 1016, 1068, 1230, 1266, 1269-1273, 1323, 1371, 1374, 1378
R/mpf_exporters.R      277      20  92.78%   2, 100-102, 147, 183, 227, 230, 235, 414-420, 424, 427, 431, 479, 557
R/page_size.R           42       1  97.62%   219
R/pagination.R         759      52  93.15%   327-330, 435-450, 540, 593, 598, 639, 677-688, 764, 876-877, 899-908, 1046, 1097-1098, 1249, 1286-1290, 1306, 1313, 1395, 1530-1531, 1547-1548, 1562-1563
R/tostring.R           783      66  91.57%   88, 296, 351, 421, 454, 462, 498, 555-558, 594, 658-661, 667-671, 674-677, 684-689, 772-773, 913-914, 979-986, 1036-1040, 1109, 1162, 1181-1185, 1196, 1214, 1231, 1246, 1344, 1385, 1430, 1516, 1555, 1609, 1616
R/utils.R                3       0  100.00%
R/zzz.R                 17       6  64.71%   28-33
TOTAL                 2949     217  92.64%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 395145b

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @llrs-roche ;)

@llrs-roche llrs-roche merged commit 935f414 into main Dec 18, 2024
30 checks passed
@llrs-roche llrs-roche deleted the svg_logo@main branch December 18, 2024 13:59
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce logo size
2 participants