Fix split list for pagination when with ordered factors

[Melkiades]

#234 #225

[github-actions]

Unit Tests Summary

  1 files   5 suites   9s ⏱️
 41 tests 31 ✅ 10 💤 0 ❌
111 runs  96 ✅ 15 💤 0 ❌

Results for commit 062dc53.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
matrix_form	👶		$+0.06$	matrix_form_detects_or_in_labels_and_sends_meaningful_error_message

Results for commit 1536a28

♻️ This comment has been updated with latest results.

[shajoezhu]

hi @Melkiades , thanks for the fix, tests currently failing, can you also add a test to
https://github.com/insightsengineering/scda.test/blob/main/tests/testthat/test-pagination_listing.R as well. thanks.

[Melkiades]

hi @Melkiades , thanks for the fix, tests currently failing, can you also add a test to https://github.com/insightsengineering/scda.test/blob/main/tests/testthat/test-pagination_listing.R as well. thanks.

After some thinking, I do not think it is necessary to add a test there as the issue is already tested here. It is not related to pagination and it is nicely self-contained here ;)

[shajoezhu]

lgtm! thanks @Melkiades

[github-actions]

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ----------------------------------------
R/paginate_listing.R        29       0  100.00%
R/rlistings_methods.R      117      26  77.78%   18-29, 49, 65, 69, 155-158, 161, 245-251
R/rlistings.R              194      14  92.78%   180, 396-399, 403-406, 435-438, 498
TOTAL                      340      40  88.24%

Diff against main

Filename         Stmts    Miss  Cover
-------------  -------  ------  -------
R/rlistings.R      +11      +1  -0.11%
TOTAL              +11      +1  +0.09%

Results for commit: 062dc53

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results