Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split package #15

Merged
merged 36 commits into from
Nov 14, 2024
Merged

split package #15

merged 36 commits into from
Nov 14, 2024

Conversation

shajoezhu
Copy link
Collaborator

No description provided.

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Unit Tests Summary

 1 files   2 suites   9s ⏱️
 8 tests  7 ✅ 1 💤 0 ❌
20 runs  19 ✅ 1 💤 0 ❌

Results for commit eabf2d3.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 9, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
Exporting to txt, pdf, rtf, and docx 💔 $1.17$ $+2.89$ $-1$ $0$ $0$ $-6$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
Exporting to txt, pdf, rtf, and docx 👶 $+0.30$ export_as_doc_produces_a_warning_if_manual_column_widths_are_used
Exporting to txt, pdf, rtf, and docx 💔 $0.20$ $+2.60$ export_as_doc_works_thanks_to_tt_to_flextable
Exporting to txt, pdf, rtf, and docx 💀 $0.03$ $-0.03$ export_as_pdf_works
Exporting to txt, pdf, rtf, and docx 💀 $0.01$ $-0.01$ export_as_rtf_works
Exporting to txt, pdf, rtf, and docx 💀 $0.02$ $-0.02$ export_as_txt_works_with_wrapping
Exporting to txt, pdf, rtf, and docx 💀 $0.01$ $-0.01$ exporting_pdf_does_the_inset
Exporting to txt, pdf, rtf, and docx 💀 $0.03$ $-0.03$ tsv_roundtripping_for_path_enriched_df

Results for commit 7e7d38e

♻️ This comment has been updated with latest results.

@shajoezhu
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

@shajoezhu shajoezhu added the sme label Nov 12, 2024
@shajoezhu shajoezhu requested a review from BFalquet November 12, 2024 04:24
@shajoezhu
Copy link
Collaborator Author

CLA passing is waiting for the PR https://github.com/insightsengineering/.github-private/pull/25 to merge

DESCRIPTION Outdated Show resolved Hide resolved
@shajoezhu
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

github-actions bot commented Nov 13, 2024

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
@shajoezhu shajoezhu requested a review from Melkiades November 14, 2024 11:00
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks Joe. Maybe we should put an actual placeholder like WIP for the main vignette. Wdyt?

@shajoezhu shajoezhu enabled auto-merge (squash) November 14, 2024 17:30
@shajoezhu shajoezhu merged commit dccd62f into main Nov 14, 2024
29 checks passed
@shajoezhu shajoezhu deleted the split_package branch November 14, 2024 17:35
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants