Skip to content

Update snapshots after formatters changes in wrapping #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 13, 2023

Conversation

Melkiades
Copy link
Contributor

No description provided.

@Melkiades Melkiades added the sme label Oct 13, 2023
WEEK 5 DAY 36 426 49.56 -22.56 300.84 -5.80 785.27 -539.53
BRA-11/171 40/F/ASIAN C: Combination BASELINE 49 76.56 NA 320.56 NA 735.92 NA
WEEK 1 DAY 8 211 33.10/L -43.45 406.68 86.12 905.99 170.06
BRA-1/105 38/M/BLACK OR AFRICAN AMERICAN A: Drug X BASELINE 149 66.94 NA 441.78 NA 896.59 NA
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we go for right align for these columns?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@edelarua edelarua Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused about how these changes happened. I ran the tests in scda.test a week or two ago and didn't get these changes, so I'm thinking it must somehow be due to the wrapping changes? I don't really know how that would cause this though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we change the default to dec_right (or decimal) at some point for listings? I think that's what is happening.

725 117 32.6 2070.7 5.5 - 31.1 7 - 55 40% / 40%
1026 301 19.7 1211.7 5.5 - 31.1 7 - 55 40% / 40%
BRA-11/id-50 72 0 21.9 NA 5.5 - 31.1 7 - 55 40% / 40%
Alanine Aminotransferase Measurement (U/L) A: Drug X BRA-1/id-105 80 0 4.3 NA 5.5 - 31.1 7 - 55 40% / 40% LL
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again right align..

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023

Unit Tests Summary

    1 files  112 suites   3m 44s ⏱️
249 tests 238 ✔️   11 💤 0
502 runs  254 ✔️ 248 💤 0

Results for commit 3c2b72c.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should merge these changes in and see what the tests return with the updates. Any corrections needed will take place in other packages

@ayogasekaram ayogasekaram enabled auto-merge (squash) October 13, 2023 19:28
@ayogasekaram ayogasekaram merged commit 00bbf7d into main Oct 13, 2023
@ayogasekaram ayogasekaram deleted the update_snapshots_aft_formatters@main branch October 13, 2023 19:36
Comment on lines +23 to +25
Rate 2.4550 2.8514 3.4304
Rate CI (1.6194, 3.7219) (1.8974, 4.2850) (2.2946, 5.1284)
Rate Ratio 1.1615 1.3973
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edelarua @ayogasekaram @Melkiades note these numbers changed a lot

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is the same issue that we were having in tern with summarize_glm_count test snapshots randomly changing - this is the only template that uses this function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants