-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
phase out of scda and intro of {pharmaverseadam} #75
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Just one suggestion since I think you accidentally deleted a word here.
Co-authored-by: Emily de la Rua <59304861+edelarua@users.noreply.github.com> Signed-off-by: Davide Garolini <dgarolini@gmail.com>
…gineering/scda.test into 74_pharmaverseadam_trial@main # Conflicts: # DESCRIPTION
Signed-off-by: Davide Garolini <dgarolini@gmail.com>
…gineering/scda.test into 74_pharmaverseadam_trial@main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Just trying to learn some of the codebase here as I onboard onto sme, mostly small comments/musings for now
Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> Signed-off-by: Davide Garolini <dgarolini@gmail.com>
Co-authored-by: Zelos Zhu <zelos.zhu@atorusresearch.com> Signed-off-by: Davide Garolini <dgarolini@gmail.com>
@zdz2101 @edelarua @ayogasekaram @khatril @shajoezhu This PR can be merged only with regards to taking out The trials regarding If this is a priority, we can merge it w/o |
Unit Test Performance Difference
Additional test case details
Results for commit b36cf5a ♻️ This comment has been updated with latest results. |
Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks guys, I think the changes look good. We should start moving on this. this PR is a good start to remove dependencies on scda
Fixes #74