Skip to content

Closes #70 pharmaverseadam update of ae templates #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Feb 14, 2024

Conversation

zdz2101
Copy link
Contributor

@zdz2101 zdz2101 commented Jan 5, 2024

Addresses portions of #70

@zdz2101 zdz2101 linked an issue Jan 5, 2024 that may be closed by this pull request
10 tasks
@zdz2101 zdz2101 marked this pull request as ready for review January 23, 2024 20:04
Copy link
Contributor

github-actions bot commented Jan 23, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
pagination_table 💚 $16.18$ $-1.73$ $0$ $0$ $0$ $0$
table_aet02 💔 $9.90$ $+66.30$ $0$ $0$ $0$ $0$
table_aet03 💔 $1.92$ $+20.77$ $0$ $0$ $0$ $0$
table_aet04 💔 $14.95$ $+212.74$ $0$ $0$ $0$ $0$
table_aet04_pi 💔 $9.37$ $+34.26$ $0$ $0$ $0$ $0$
table_aet09 💔 $1.49$ $+16.14$ $0$ $0$ $0$ $0$
table_ent 💚 $19.23$ $-1.73$ $0$ $0$ $0$ $0$
table_lbt05 💚 $24.99$ $-1.88$ $0$ $0$ $0$ $0$
table_lbt14 💚 $131.64$ $-27.90$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
table_aet02 💔 $0.65$ $+2.51$ AET02_variant_10_is_produced_correctly
table_aet02 💔 $0.75$ $+3.12$ AET02_variant_11_is_produced_correctly
table_aet02 💔 $0.66$ $+2.62$ AET02_variant_12_is_produced_correctly
table_aet02 💔 $1.00$ $+3.60$ AET02_variant_1_is_produced_correctly
table_aet02 💔 $1.15$ $+4.11$ AET02_variant_2_is_produced_correctly
table_aet02 💔 $1.37$ $+21.32$ AET02_variant_3_is_produced_correctly
table_aet02 💔 $0.24$ $+1.93$ AET02_variant_4_is_produced_correctly
table_aet02 💔 $0.77$ $+2.91$ AET02_variant_5_is_produced_correctly
table_aet02 💔 $0.70$ $+2.30$ AET02_variant_6_is_produced_correctly
table_aet02 💔 $1.21$ $+17.08$ AET02_variant_7_is_produced_correctly
table_aet02 💔 $0.67$ $+2.34$ AET02_variant_8_is_produced_correctly
table_aet02 💔 $0.73$ $+2.45$ AET02_variant_9_is_produced_correctly
table_aet03 💔 $1.92$ $+20.77$ AET03_variant_1_is_produced_correctly
table_aet04 💔 $0.46$ $+6.84$ AET04_variant_11_is_produced_correctly_with_Incidence_Rate_of_at_Least_X_all_SOCs_w_o_preferred_terms_removed_
table_aet04 💔 $2.78$ $+39.44$ AET04_variant_1_is_produced_correctly
table_aet04 💔 $2.50$ $+25.46$ AET04_variant_2_is_produced_correctly_Fill_in_of_Treatment_Groups_
table_aet04 💔 $3.18$ $+48.12$ AET04_variant_3_is_produced_correctly_Fill_in_of_Grades_
table_aet04 💔 $2.53$ $+38.17$ AET04_variant_4_is_produced_correctly_Collapsing_of_Grades_grades_1_2_grades_3_4_5_
table_aet04 💔 $2.57$ $+39.82$ AET04_variant_6_is_produced_correctly_with_an_Incidence_Rate_of_at_Least_5_totals_restricted_
table_aet04 💔 $0.45$ $+7.42$ AET04_variant_8_is_produced_correctly_with_an_Incidence_Rate_of_at_Least_X_Patients_
table_aet04 💔 $0.48$ $+7.46$ AET04_variant_9_is_produced_correctly_with_a_Difference_in_Incidence_Rate_of_at_Least_X_
table_aet04_pi 💔 $1.10$ $+4.54$ AET04_PI_full_table_is_produced_correctly
table_aet04_pi 💔 $1.11$ $+3.55$ AET04_PI_variant_1_is_produced_correctly
table_aet04_pi 💔 $1.12$ $+5.43$ AET04_PI_variant_2_is_produced_correctly
table_aet04_pi 💔 $1.05$ $+3.53$ AET04_PI_variant_3_is_produced_correctly
table_aet04_pi 💔 $1.03$ $+3.55$ AET04_PI_variant_4_is_produced_correctly
table_aet04_pi 💔 $1.06$ $+3.68$ AET04_PI_variant_5_is_produced_correctly
table_aet04_pi 💔 $1.27$ $+4.62$ AET04_PI_variant_6_is_produced_correctly
table_aet04_pi 💔 $1.30$ $+4.14$ AET04_PI_variant_7_is_produced_correctly
table_aet04_pi 💔 $0.34$ $+1.23$ AET04_PI_variant_8_is_produced_correctly
table_aet09 💔 $0.66$ $+2.68$ AET09_variant_1_is_produced_correctly_AE_related_to_study_drug
table_aet09 💔 $0.82$ $+13.46$ AET09_variant_2_is_produced_correctly_AE_related_to_study_drug_including_high_level_terms_
table_lbt14 💚 $28.66$ $-5.73$ LBT14_variant_1_HIGH_works_as_expected
table_lbt14 💚 $27.79$ $-6.31$ LBT14_variant_2_LOW_works_as_expected
table_lbt14 💚 $8.94$ $-1.91$ LBT14_variant_3_LOW_without_baseline_missing_works_as_expected
table_lbt14 💚 $25.14$ $-5.23$ LBT14_variant_4_LOW_and_force_1_missing_both_baseline_and_post_baseline_then_force_the_missing_baseline_as_0_as_expected
table_lbt14 💚 $41.11$ $-8.73$ LBT14_variant_5_HIGH_with_fillings_works_as_expected

Results for commit 7236ab7

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 23, 2024

Unit Tests Summary

  1 files  110 suites   11m 6s ⏱️
244 tests 233 ✅  11 💤 0 ❌
497 runs  255 ✅ 242 💤 0 ❌

Results for commit af34644.

♻️ This comment has been updated with latest results.

@zdz2101 zdz2101 requested a review from Melkiades January 24, 2024 16:37
@shajoezhu shajoezhu added the sme label Jan 26, 2024
@khatril khatril self-requested a review February 1, 2024 11:03
Copy link
Contributor Author

@zdz2101 zdz2101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khatril The things you raised have been addressed, I modified the numbers in aet04_pi to get all variants to render, otherwise structurally the table cutoff tables you had mentioned in aet04 look the same as the ones in tlg

@khatril khatril self-requested a review February 14, 2024 09:03
@zdz2101 zdz2101 enabled auto-merge (squash) February 14, 2024 15:11
@zdz2101 zdz2101 disabled auto-merge February 14, 2024 15:11
@zdz2101 zdz2101 merged commit b0ea5cc into main Feb 14, 2024
@zdz2101 zdz2101 deleted the 70_pharmaverseadam_update_ae_templates branch February 14, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pharmaverseadam]: Update to admiral data for AE templates
4 participants