Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #95 upversion DESCRIPTION file #96

Closed
wants to merge 2 commits into from
Closed

Closes #95 upversion DESCRIPTION file #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52d7a95
feat: #95 upversion DESCRIPTION file
zdz2101 Jan 9, 2024
3d04417
chore: #95 remove temp fix
zdz2101 Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Depends:
rtables (>= 0.6.6),
tern (>= 0.9.3.9002)
Imports:
pharmaverseadam (>= 0.1.1),
pharmaverseadam (>= 0.2.0),
random.cdisc.data (>= 0.3.14.9002)
Suggests:
broom,
Expand Down
1 change: 0 additions & 1 deletion tests/testthat/test-listing_pkpl01.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ testthat::test_that("PKPL01 listing is produced correctly", {

out <- adpp_x %>%
mutate(PARAM = paste0(PARAMCD, " (", PPORRESU, ")")) %>%
mutate(TRT01A = TRT01A.x) %>% # This is a temp fix
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! We need to fix the error first:

── Error ('test-listing_pkpl01.R:13:3'): PKPL01 listing is produced correctly ──
  <dplyr:::mutate_error/rlang_error/error/condition>
  Error in `mutate(., TRT01A = TRT01A.x)`: i In argument: `TRT01A = TRT01A.x`.
  Caused by error:
  ! object 'TRT01A.x' not found

@Melkiades this modification should do the trick

select(TRT01A, USUBJID, AVISIT, PARAM, AVAL) %>%
unique() %>% # This is a temp fix, as avisit was added this way
tidyr::pivot_wider(
Expand Down
Loading