Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1441 Introduce transformators parameter in modules #399

Merged
merged 10 commits into from
Jan 24, 2025
Merged

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Jan 21, 2025

insightsengineering/teal#1441

Included transformators parameter in modules. This is passed to teal::module that does assertions and checks on this parameter.

Copy link
Contributor

github-actions bot commented Jan 21, 2025

Unit Tests Summary

 1 files  15 suites   9s ⏱️
56 tests 43 ✅ 13 💤 0 ❌
94 runs  81 ✅ 13 💤 0 ❌

Results for commit fa85af1.

♻️ This comment has been updated with latest results.

@gogonzo gogonzo self-assigned this Jan 22, 2025
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All module() calls covered

@m7pr
Copy link
Contributor Author

m7pr commented Jan 22, 2025

Will merge this PR after we vbump teal and it's dependencies. Will try to satisfy that in another PR that will be meant just for fixing Scheduled Jobs

@m7pr
Copy link
Contributor Author

m7pr commented Jan 24, 2025

Blocked by this #400

@m7pr m7pr enabled auto-merge (squash) January 24, 2025 11:33
@m7pr m7pr merged commit 8005f31 into main Jan 24, 2025
28 of 29 checks passed
@m7pr m7pr deleted the 1441_transformators@main branch January 24, 2025 11:52
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants