-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
post-release-cleanup #247
post-release-cleanup #247
Conversation
Code Coverage Summary
Diff against main
Results for commit: 37db571 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 18 suites 12s ⏱️ Results for commit 37db571. ♻️ This comment has been updated with latest results. |
Wow, nice changes! Since this is not targeting the |
thanks @vedhav , I have fixed the linter issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! You're becoming a doc-fixing ninja 🥷
Ready to merge after the pkgdown fix.
…s@main # Conflicts: # DESCRIPTION # NEWS.md # inst/WORDLIST
I think the skipping Created: #248 |
Merge branch 'additional_changes@273-pre-release-activities@main' of https://github.com/insightsengineering/teal.reporter into additional_changes@273-pre-release-activities@main # Conflicts: # R/Reporter.R
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No major comments at this time.
…ttps://github.com/insightsengineering/teal.reporter into additional_changes@273-pre-release-activities@main
Unit Test Performance DifferenceAdditional test case details
Results for commit bf714db ♻️ This comment has been updated with latest results. |
Merge branch 'main' into additional_changes@273-pre-release-activities@main # Conflicts: # DESCRIPTION # R/utils.R # man/split_text_block.Rd # man/teal.reporter-package.Rd
…)" This reverts the doc change from the commit 78a5aab
this PR is part of #246
I have added few changes to keep it consistent with other pre-release-cleanup
pkg::
call from examples and uselibrary(pkg)