Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post-release-cleanup #247

Merged

Conversation

kartikeyakirar
Copy link
Contributor

@kartikeyakirar kartikeyakirar commented Feb 15, 2024

this PR is part of #246

I have added few changes to keep it consistent with other pre-release-cleanup

  • title and description to have sentence cases.
  • common document for module instead of separate for UI and server
    • download_report_button
    • add_card_button
    • reporter_previewer
    • reset_report_button
    • simple_reporter
  • removing indentation-linter
  • removing \cr tags
  • putting backticks on keywords e.g R6, shiny or [pkg]
  • removing pkg:: call from examples and use library(pkg)

@kartikeyakirar kartikeyakirar marked this pull request as draft February 15, 2024 09:57
@kartikeyakirar kartikeyakirar changed the base branch from main to 237-pre-release-activities@main February 15, 2024 09:57
Copy link
Contributor

github-actions bot commented Feb 15, 2024

badge

Code Coverage Summary

Filename              Stmts    Miss  Cover    Missing
------------------  -------  ------  -------  -----------------------------------------------------------------------------------
R/AddCardModule.R       144       2  98.61%   165, 202
R/Archiver.R             25       0  100.00%
R/ContentBlock.R         18       2  88.89%   57-63
R/DownloadModule.R      207      49  76.33%   98-104, 146, 177-182, 191-195, 198-202, 210-214, 217-221, 228-232, 235-239, 278-282
R/FileBlock.R            13       0  100.00%
R/NewpageBlock.R          2       0  100.00%
R/PictureBlock.R         30       2  93.33%   20, 118
R/Previewer.R           295      56  81.02%   198, 213, 215-218, 221, 224-232, 346-390
R/RcodeBlock.R           15       0  100.00%
R/Renderer.R            113      37  67.26%   97-112, 216, 224, 233, 235-256
R/ReportCard.R           77       4  94.81%   192, 233, 238, 259
R/Reporter.R             94       1  98.94%   270
R/ResetModule.R          55       0  100.00%
R/SimpleReporter.R       30       0  100.00%
R/TableBlock.R            9       0  100.00%
R/TextBlock.R            13       0  100.00%
R/utils.R               171      80  53.22%   7, 38-97, 99, 102-109, 167, 179-181, 285-294
R/yaml_utils.R           81       2  97.53%   79, 290
R/zzz.R                  14      10  28.57%   2-13, 19
TOTAL                  1406     245  82.57%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 37db571

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Feb 15, 2024

Unit Tests Summary

  1 files   18 suites   12s ⏱️
204 tests 204 ✅ 0 💤 0 ❌
346 runs  346 ✅ 0 💤 0 ❌

Results for commit 37db571.

♻️ This comment has been updated with latest results.

@kartikeyakirar kartikeyakirar marked this pull request as ready for review February 15, 2024 14:24
@kartikeyakirar kartikeyakirar mentioned this pull request Feb 15, 2024
24 tasks
@vedhav
Copy link
Contributor

vedhav commented Feb 15, 2024

Wow, nice changes! Since this is not targeting the main the actions are not triggered. Can you try running lintr::lint_package() and catch the lint errors?

_pkgdown.yml Outdated Show resolved Hide resolved
@kartikeyakirar
Copy link
Contributor Author

thanks @vedhav , I have fixed the linter issue.
image

Copy link
Contributor

@vedhav vedhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! You're becoming a doc-fixing ninja 🥷
Ready to merge after the pkgdown fix.

R/AddCardModule.R Outdated Show resolved Hide resolved
R/AddCardModule.R Outdated Show resolved Hide resolved
R/Archiver.R Show resolved Hide resolved
R/Archiver.R Outdated Show resolved Hide resolved
…s@main

# Conflicts:
#	DESCRIPTION
#	NEWS.md
#	inst/WORDLIST
@kartikeyakirar kartikeyakirar changed the title additonal changes to pre-release-cleanup post-release-cleanup Feb 16, 2024
@averissimo
Copy link
Contributor

I think the skipping Suggest packages in examples, tests & vignettes should become its own issue as it will require some code changes in tests.

Created: #248

Merge branch 'additional_changes@273-pre-release-activities@main' of https://github.com/insightsengineering/teal.reporter into additional_changes@273-pre-release-activities@main

# Conflicts:
#	R/Reporter.R
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves the _pkgdown.yml problem with building site

Built locally

image

_pkgdown.yml Outdated Show resolved Hide resolved
_pkgdown.yml Outdated Show resolved Hide resolved
_pkgdown.yml Show resolved Hide resolved
_pkgdown.yml Outdated Show resolved Hide resolved
_pkgdown.yml Outdated Show resolved Hide resolved
Signed-off-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
@kartikeyakirar
Copy link
Contributor Author

Thank you, @chlebowa and @vedhav, for your review and approval. I've made some updates to the documentation and vignette and have pushed these changes. Could you please take a look at this commit? before final merge 7fd7c87

Copy link
Contributor

@chlebowa chlebowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major comments at this time.

R/PictureBlock.R Outdated Show resolved Hide resolved
R/PictureBlock.R Outdated Show resolved Hide resolved
R/Renderer.R Outdated Show resolved Hide resolved
R/Renderer.R Outdated Show resolved Hide resolved
R/ReportCard.R Outdated Show resolved Hide resolved
R/ReportCard.R Outdated Show resolved Hide resolved
R/ReportCard.R Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Feb 19, 2024

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
PictureBlock 👶 $+0.01$ set_content_raises_error_if_the_content_is_not_of_the_supported_type
PictureBlock 💀 $0.01$ $-0.01$ set_content_throws_if_the_content_is_not_of_the_supported_type

Results for commit bf714db

♻️ This comment has been updated with latest results.

@kartikeyakirar kartikeyakirar enabled auto-merge (squash) February 19, 2024 16:26
dependabot-preview bot and others added 3 commits February 19, 2024 16:26
Merge branch 'main' into additional_changes@273-pre-release-activities@main

# Conflicts:
#	DESCRIPTION
#	R/utils.R
#	man/split_text_block.Rd
#	man/teal.reporter-package.Rd
@kartikeyakirar kartikeyakirar merged commit 78a5aab into main Feb 19, 2024
26 checks passed
@kartikeyakirar kartikeyakirar deleted the additional_changes@273-pre-release-activities@main branch February 19, 2024 18:31
vedhav added a commit that referenced this pull request Feb 22, 2024
vedhav added a commit that referenced this pull request Feb 22, 2024
…)"

This reverts the doc change from the commit 78a5aab
donyunardi pushed a commit that referenced this pull request Feb 22, 2024
…)" (#254)

This reverts the doc change from the commit
78a5aab

---------

Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants