-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rtables.officer
as a dependency
#289
Conversation
Code Coverage Summary
Diff against main
Results for commit: 5d0f720 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 18 suites 26s ⏱️ Results for commit 5d0f720. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Results for commit c4edd53 ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Vedha! ;) Lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot @vedhav for the changes, I think it all looks good. i was wondering if the new changes in rtables, is blocking teal package development? If not, can we work together with the release plan. Thanks!
Thanks @shajoezhu we do not plan to release the |
Changes:
rtables
versionrtables.officer
as a new dependencyNote that this blocks CRAN release of
teal.reporter
untill thertables.officer
andrtables
is released.