Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rtables.officer as a dependency #289

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Add rtables.officer as a dependency #289

merged 2 commits into from
Nov 19, 2024

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented Nov 18, 2024

Changes:

  1. Updates the rtables version
  2. Adds rtables.officer as a new dependency

Note that this blocks CRAN release of teal.reporter untill the rtables.officer and rtables is released.

@vedhav vedhav requested a review from a team November 18, 2024 07:27
@shajoezhu shajoezhu self-requested a review November 18, 2024 07:31
Copy link
Contributor

badge

Code Coverage Summary

Filename                  Stmts    Miss  Cover    Missing
----------------------  -------  ------  -------  -----------------------------------------------------------------------------------------------------
R/AddCardModule.R           146       2  98.63%   170, 207
R/ContentBlock.R             18       2  88.89%   57-63
R/DownloadModule.R          238      67  71.85%   98-104, 152, 183-188, 197-202, 205-210, 219-224, 227-232, 240-245, 248-253, 260-265, 268-273, 312-316
R/FileBlock.R                13       0  100.00%
R/LoadReporterModule.R      103      19  81.55%   100-105, 108-113, 119-124, 136
R/NewpageBlock.R              2       0  100.00%
R/PictureBlock.R             30       2  93.33%   20, 118
R/Previewer.R               372      95  74.46%   96-98, 101-102, 184-213, 217-219, 222, 289, 304, 306-309, 312, 315-323, 437-481
R/RcodeBlock.R               15       0  100.00%
R/Renderer.R                113      37  67.26%   97-112, 216, 224, 233, 235-256
R/ReportCard.R               84       3  96.43%   239, 244, 269
R/Reporter.R                107       6  94.39%   273-278
R/ResetModule.R              53       0  100.00%
R/SimpleReporter.R           32       0  100.00%
R/TableBlock.R                9       0  100.00%
R/TextBlock.R                13       0  100.00%
R/utils.R                   126      86  31.75%   7, 38-97, 99, 102-109, 137, 161-169, 206-215
R/yaml_utils.R               81       2  97.53%   78, 289
R/zzz.R                      14      10  28.57%   2-13, 19
TOTAL                      1569     331  78.90%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 5d0f720

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Nov 18, 2024

Unit Tests Summary

  1 files   18 suites   26s ⏱️
189 tests 189 ✅ 0 💤 0 ❌
329 runs  329 ✅ 0 💤 0 ❌

Results for commit 5d0f720.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 18, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
ReportCard 💚 $4.47$ $-1.24$ $0$ $0$ $0$ $0$
TableBlock 💚 $12.16$ $-3.11$ $0$ $0$ $0$ $0$

Results for commit c4edd53

♻️ This comment has been updated with latest results.

Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Vedha! ;) Lgtm

Copy link

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot @vedhav for the changes, I think it all looks good. i was wondering if the new changes in rtables, is blocking teal package development? If not, can we work together with the release plan. Thanks!

@vedhav
Copy link
Contributor Author

vedhav commented Nov 19, 2024

Thanks @shajoezhu we do not plan to release the teal.reporter this increment so we can follow the rtables release plan.

@vedhav vedhav merged commit 953bca0 into main Nov 19, 2024
34 of 49 checks passed
@vedhav vedhav deleted the add-rtables.officer@main branch November 19, 2024 07:46
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants