-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close 1089 use title case in default module label #1459
base: main
Are you sure you want to change the base?
Close 1089 use title case in default module label #1459
Conversation
✅ All contributors have signed the CLA |
I have read the CLA Document and I hereby sign the CLA |
Hi Lluis: Hope another easy issue: |
This PR has changes not related to the title. Please restore the RStudio teal.Rproj file. |
…com:jimrothstein/teal into 1089_use_title_case_in_default_module_label
@llrs-roche |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
It seems there are two tests affected by this change (The coverage is much higher than I expected).
Can you fix them? |
Will fix the tests |
Head branch was pushed to by a user without write access
Did fix problem in Question:
|
Github actions are run only after they are approved (due to people abusing it for bitcoin mining and other bad purposes). I approved them now and will merge once they pass. Thanks again! About testing the library locally: as we are getting closer to a release there are a lot of new features that do not work with CRAN's version. You'll need to install or load all the development versions of the packages (teal.code, teal.slice, teal.reporter, teal.logger, ...). You should install de development (aka the versions on branch main that build from https://pharmaverse.r-universe.dev/builds: |
Pull Request
Fixes #1089