Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close 1089 use title case in default module label #1459

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

jimrothstein
Copy link

Pull Request

Fixes #1089

Copy link
Contributor

github-actions bot commented Jan 22, 2025

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@jimrothstein
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@jimrothstein
Copy link
Author

@llrs-roche

Hi Lluis:

Hope another easy issue:

@llrs-roche
Copy link
Contributor

This PR has changes not related to the title. Please restore the RStudio teal.Rproj file.
Other than that it is fine. Thanks!

@jimrothstein
Copy link
Author

@llrs-roche
Had to fix my .gitignore file; :(

Copy link
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@llrs-roche llrs-roche enabled auto-merge (squash) January 23, 2025 08:51
@llrs-roche
Copy link
Contributor

It seems there are two tests affected by this change (The coverage is much higher than I expected).

  ══ Failed tests ════════════════════════════════════════════════════════════════
  ── Failure ('test-report_previewer_module.R:24:3'): report_previewer_module default label is Report previewer  ──
  r_p_m$label not equal to "Report previewer".
  1/1 mismatches
  x[1]: "Report Previewer"
  y[1]: "Report previewer"
  ── Failure ('test-shinytest2-reporter.R:16:3'): e2e: reporter tab is created when a module has reporter ──
  `tab_names` not identical to c(`Module with Reporter` = "module_with_reporter", `Report previewer` = "report_previewer").
  Names: 1 string mismatch

Can you fix them?

@jimrothstein
Copy link
Author

Will fix the tests

auto-merge was automatically disabled January 23, 2025 22:00

Head branch was pushed to by a user without write access

@jimrothstein
Copy link
Author

jimrothstein commented Jan 24, 2025

@llrs-roche

Did fix problem in test-report_previewer_module.R, but I can not tell if gh workflow ran without errors.

Question:
On my local machine, I cloned a copy of teal , create a branch and open it in Rstudio. load_all() is giving me local errors about dependencies. Suggestions how I should configure my local machine for development? Thx

`manually, ran pak::pak(....) for each teal dependency.   load_all() works`

.Last.error
<callr_error/rlib_error_3_0/rlib_error/error>
Error: 
! error in pak subprocess
Caused by error: 
! Could not solve package dependencies:
* local::/home/jim/code/teal:
  * Can't install dependency teal.data (>= 0.6.0.9017) (>= 0.5.1.9022) (>= 0.5.0.9022) (>= 0.3.1.9023)
  * Can't install dependency teal.slice (>= 0.5.1.9022) (>= 0.5.0.9022) (>= 0.3.1.9023)
  * Can't install dependency teal.code (>= 0.5.0.9022) (>= 0.3.1.9023)
  * Can't install dependency teal.reporter (>= 0.3.1.9023)
---
Backtrace:
 1. devtools::load_all()
 2. pkgload::load_all(path = path, reset = reset, recompile = recompile, …
 3. pkgload:::load_depends(path, quiet = quiet)
 4. pkgload:::deps_check_installed(path, depends)
 5. rlang::check_installed(pkg, action = action, call = call)
 6. local action(missing_pkgs)
 7. pak::local_deps(path, upgrade = FALSE)
 8. pak::pkg_deps(ref, upgrade = upgrade, dependencies = dependencies)
 9. pak:::remote(function(...) { …
10. err$throw(res$error)
---
Subprocess backtrace:
1. base::withCallingHandlers(cli_message = function(msg) { …
2. get("pkg_deps_internal", asNamespace("pak"))(...)
3. pak:::pkg_deps_internal2(pkg, upgrade, dependencies)
4. deps$stop_for_solution_error()
5. private$plan$stop_for_solve_error()
6. pkgdepends:::pkgplan_stop_for_solve_error(self, private)
7. base::throw(new_error("Could not solve package dependencies:\n", msg, …
8. | base::signalCondition(cond)
9. global (function (e) …

@llrs-roche
Copy link
Contributor

Github actions are run only after they are approved (due to people abusing it for bitcoin mining and other bad purposes). I approved them now and will merge once they pass. Thanks again!

About testing the library locally: as we are getting closer to a release there are a lot of new features that do not work with CRAN's version. You'll need to install or load all the development versions of the packages (teal.code, teal.slice, teal.reporter, teal.logger, ...).

You should install de development (aka the versions on branch main that build from https://pharmaverse.r-universe.dev/builds: install.packages(teal_packages, repos = c('https://pharmaverse.r-universe.dev', 'https://cloud.r-project.org')). This should take care of most if not all of the problems with dependencies.
We will make this easier to deal with in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use title case in default module label
2 participants