-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remotes cleanup refactoring, code cleanup & bug fixing #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
averissimo
force-pushed
the
training-cleanup
branch
from
August 1, 2023 14:07
11190a7
to
bb91882
Compare
averissimo
commented
Aug 1, 2023
averissimo
commented
Aug 1, 2023
averissimo
commented
Aug 1, 2023
averissimo
commented
Aug 1, 2023
averissimo
changed the title
Training cleanup
Remotes cleanup refactoring, code cleanup & bug fixing
Aug 1, 2023
This reverts commit 2a63d94.
pawelru
reviewed
Aug 21, 2023
pawelru
reviewed
Aug 21, 2023
pawelru
reviewed
Aug 21, 2023
pawelru
reviewed
Aug 21, 2023
pawelru
reviewed
Aug 21, 2023
Co-authored-by: Pawel Rucki <12943682+pawelru@users.noreply.github.com> Signed-off-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
averissimo
force-pushed
the
training-cleanup
branch
from
August 21, 2023 15:20
a7d0f25
to
fce38e3
Compare
pawelru
reviewed
Aug 24, 2023
pawelru
approved these changes
Aug 24, 2023
This is awesome. Thank you! I have approved this. Let's merge it to the training branch and then the training to the main. I will let you decide when you want to pull the trigger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of changes description
note: I've added some comments in the code below for additional context.
desc_remotes_cleanup()
refactoring just as we discussedRemotes
while keeping functionalitysolve_*
functions to own filedesc_util.R
, for description-based functions)local_description()
moved toR/
remote_github_ref
to CRAN when resolving packages if that version (rule) exists on CRANformatters (>= 0.5.1)
isn't on CRAN, so it keeps the github_ref (instead of replacing with non-existent CRAN versions)parse_ppm_url()
fallback to lastest from PPM if snapshot date cannot be resolvedmap_key_character
to avoid repetitivevapply()