Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove workaround; use devel of pkgcache #54

Closed
wants to merge 3 commits into from
Closed

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Aug 20, 2024

We have a workaround for a bug that had been fixed on main so let's use this and remove workaround

Copy link
Contributor

github-actions bot commented Aug 20, 2024

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  -------------------------------------------
R/check.R                            73      73  0.00%    27-224
R/deps_installation_proposal.R      143     143  0.00%    62-280
R/desc_utils.R                       96      43  55.21%   15-32, 108, 117-122, 172, 195, 208-247, 265
R/get_ref.R                         244     243  0.41%    13-506, 525-568
R/solve.R                            84      84  0.00%    9-170
R/utils.R                            63      49  22.22%   3-23, 36-100
TOTAL                               703     635  9.67%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  -------
R/utils.R        -3      +7  -14.14%
TOTAL            -3      +7  -1.38%

Results for commit: d501b0a

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Aug 20, 2024

Unit Tests Summary

 1 files   4 suites   1s ⏱️
45 tests 15 ✅ 30 💤 0 ❌
98 runs  67 ✅ 31 💤 0 ❌

Results for commit d501b0a.

♻️ This comment has been updated with latest results.

Copy link
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
utils 💔 $0.66$ $+3.66$ $+1$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
utils 💔 $0.49$ $+3.67$ get_ppm_snapshot_by_date_will_accept_NA

Results for commit 4807ca3

♻️ This comment has been updated with latest results.

@pawelru
Copy link
Contributor Author

pawelru commented Aug 30, 2024

this had been included in #56

@pawelru pawelru closed this Aug 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
@pawelru pawelru deleted the rm_workaround branch August 30, 2024 12:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant