Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add useScroll hook #77

Closed
wants to merge 2 commits into from
Closed

feat: add useScroll hook #77

wants to merge 2 commits into from

Conversation

immois
Copy link
Contributor

@immois immois commented Nov 29, 2023

Closes

πŸ“ Description:

βœ… Pull Request Checklist:

  • Add/Update feature.
  • Add/Update test.
  • Add/Update documentation.
  • Add/Update stories in storybook.
  • Bug fix.
  • Is this a breaking change

Copy link

changeset-bot bot commented Nov 29, 2023

⚠️ No Changeset found

Latest commit: 879c132

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (a4c1558) 92.71% compared to head (879c132) 87.07%.

Files Patch % Lines
packages/hooks/use-scroll/src/index.ts 0.00% 15 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   92.71%   87.07%   -5.65%     
==========================================
  Files          16       17       +1     
  Lines         247      263      +16     
  Branches       63       67       +4     
==========================================
  Hits          229      229              
- Misses         16       31      +15     
- Partials        2        3       +1     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@immois immois closed this Dec 16, 2023
@immois immois deleted the feat/use-scroll branch December 22, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant