Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useEventListener): add variables for SSR support #78

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

immois
Copy link
Contributor

@immois immois commented Dec 8, 2023

πŸ“ Description:

Add variables for window and document with SSR support

βœ… Pull Request Checklist:

  • Add/Update feature.
  • Add/Update test.
  • Add/Update documentation.
  • Add/Update stories in storybook.
  • Bug fix.
  • Is this a breaking change

Add variables for window and document with SSR support
Copy link

changeset-bot bot commented Dec 8, 2023

⚠️ No Changeset found

Latest commit: e7f2476

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a4c1558) 92.71% compared to head (e7f2476) 92.40%.

Files Patch % Lines
packages/hooks/use-event-listener/src/index.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   92.71%   92.40%   -0.32%     
==========================================
  Files          16       16              
  Lines         247      250       +3     
  Branches       63       65       +2     
==========================================
+ Hits          229      231       +2     
- Misses         16       17       +1     
  Partials        2        2              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@immois immois marked this pull request as ready for review December 8, 2023 04:47
@immois immois merged commit 52610e8 into main Dec 8, 2023
4 of 6 checks passed
@immois immois deleted the feat/use-event-listener branch December 8, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant