Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rest and DB Interceptors #3

Merged

Conversation

grove693
Copy link

@grove693 grove693 commented Sep 19, 2024

Changes:

  • added logging via slf4j api
  • fixed RestInterceptor issue with consuming the http request
  • replaced HibernateInterceptor with JDBCInterceptor which intercepts queryes/statements at the JDBC level
    • used p6spy-spring-boot-starter wrapper library for the jdbc interceptor functionality
      - official repo here
    • the underlying library providing the interceptor functionality is P6spy:
      - P6Spy is intended to be a database logging library and by default it intercepts and logs every SQL statement
      - official docs here
      - in order to disable the default logging by P6spy I have added the spy.properties which is the property file needed to configure the P6Spy library
      - normally, the P6Spy logging behavior should have been disabled by the p6spy-spring-boot-starter wrapper library but its newer versions have compatibility issues with Spring Boot v 2.x
      - check the issue here: here
  • moved the Inspector object in a ThreadLocal wrapper so that a fresh copy would be available to every thread (to avoid race conditions issues)

Copy link

sonarqubecloud bot commented Oct 1, 2024

@ilvalerione ilvalerione merged commit 084ba7e into inspector-apm:main Oct 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants