Feat: Support latest Jumanji version#1134
Merged
WiemKhlifi merged 21 commits intodevelopfrom Dec 6, 2024
Merged
Conversation
RuanJohn
requested changes
Nov 12, 2024
Collaborator
RuanJohn
left a comment
There was a problem hiding this comment.
Thanks for this @WiemKhlifi! Just a few questions, but it looks mostly good to me.
As a sanity check can you please do a few test runs to just check that the system performance is unaffected?
sash-a
requested changes
Nov 20, 2024
Collaborator
sash-a
left a comment
There was a problem hiding this comment.
Thanks Wiem, couple small things, mostly removing the git stuff from requirements.txt where possible
RuanJohn
requested changes
Nov 26, 2024
Collaborator
RuanJohn
left a comment
There was a problem hiding this comment.
Thanks @WiemKhlifi. Some suggestions from my side.
RuanJohn
requested changes
Dec 3, 2024
Collaborator
RuanJohn
left a comment
There was a problem hiding this comment.
Just a marl-eval dependency suggestion.
sash-a
approved these changes
Dec 6, 2024
sash-a
pushed a commit
that referenced
this pull request
Dec 13, 2024
Feat: Support latest Jumanji version
sash-a
pushed a commit
that referenced
this pull request
Jan 10, 2025
- chore:add git path to marll-eval - Merge branch develop into feat/update_juamnji - ci: increase time-out to 10 - chore: set the default aggregate_rewards to True - chore: cleaning based on review - Merge branch develop into feat/update_juamnji - Merge branch develop into feat/update_juamnji - ci: remove git path from requirements - fix: use cached action_spec - revert: add mpe to configs - chore: pin to latest jumanji now - Merge branch develop into feat/update_juamnji - feat: use multi-agent connector instead - chore: remove uneeded comments - Merge branch develop into feat/update_juamnji - chore: remove extra space - feat: fully support recent jumanji! - fix: fix connector shape bug - feat: add cached_prop decorator to all specs - feat: Remove Maconnector and use connector from main jumanji - feat: update jumanji version Co-authored-by: Ruan de Kock <33461981+RuanJohn@users.noreply.github.com>
sash-a
pushed a commit
that referenced
this pull request
Jan 10, 2025
- chore:add git path to marll-eval - Merge branch develop into feat/update_juamnji - ci: increase time-out to 10 - chore: set the default aggregate_rewards to True - chore: cleaning based on review - Merge branch develop into feat/update_juamnji - Merge branch develop into feat/update_juamnji - ci: remove git path from requirements - fix: use cached action_spec - revert: add mpe to configs - chore: pin to latest jumanji now - Merge branch develop into feat/update_juamnji - feat: use multi-agent connector instead - chore: remove uneeded comments - Merge branch develop into feat/update_juamnji - chore: remove extra space - feat: fully support recent jumanji! - fix: fix connector shape bug - feat: add cached_prop decorator to all specs - feat: Remove Maconnector and use connector from main jumanji - feat: update jumanji version
sash-a
pushed a commit
that referenced
this pull request
Apr 14, 2025
- chore:add git path to marll-eval - Merge branch develop into feat/update_juamnji - ci: increase time-out to 10 - chore: set the default aggregate_rewards to True - chore: cleaning based on review - Merge branch develop into feat/update_juamnji - Merge branch develop into feat/update_juamnji - ci: remove git path from requirements - fix: use cached action_spec - revert: add mpe to configs - chore: pin to latest jumanji now - Merge branch develop into feat/update_juamnji - feat: use multi-agent connector instead - chore: remove uneeded comments - Merge branch develop into feat/update_juamnji - chore: remove extra space - feat: fully support recent jumanji! - fix: fix connector shape bug - feat: add cached_prop decorator to all specs - feat: Remove Maconnector and use connector from main jumanji - feat: update jumanji version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Upgrade to the latest Jumanji version of
1.0.1instead of0.3.1and pin to the original and latestJumanjiandMatrax.How?
requirements.txtto use original versions instead of a fork.Extra:
super().__init__(env)( Theself.__getattr__(env,name)in parent class can't get the attribute from env if it's defined with different name in the env wrapper class).For example: