Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pipeline to trigger on PR merge and publish packages to npmjs #26

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

disha-148
Copy link
Collaborator

Resolved issue where files were out of sync.

@@ -26,16 +26,26 @@ jobs:
node-version: '18'
registry-url: 'https://registry.npmjs.org'

- name: Install dependencies
run: npm ci
# - name: Install dependencies
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove those unused & commented code?

run: |
npm install --package-lock-only
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will update the package-lock.json every time when something is changed. May I know what will trigger such update?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update to package-lock.json is triggered when there is a mismatch between the package.json file and the current state of the package-lock.json.

@disha-148 disha-148 marked this pull request as ready for review January 21, 2025 14:52
@morningspace morningspace merged commit b09014a into instana:main Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants