feat: MVP Knowledge #1256

thewbuk · 2024-06-20T13:40:56Z

Because

The first 3 tabs in the Knowledge section

github-actions · 2024-06-20T14:04:07Z

📦 Next.js Bundle Analysis for instillai-console

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`77.64 KB` (2 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions · 2024-06-20T14:42:29Z

📦 Next.js Bundle Analysis for instillai-console

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`77.64 KB` (2 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions · 2024-06-20T14:49:50Z

📦 Next.js Bundle Analysis for instillai-console

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`77.64 KB` (2 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions · 2024-06-20T14:55:48Z

📦 Next.js Bundle Analysis for instillai-console

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`77.64 KB` (2 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions · 2024-06-20T16:04:58Z

📦 Next.js Bundle Analysis for instillai-console

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`77.64 KB` (2 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions · 2024-06-20T18:27:23Z

📦 Next.js Bundle Analysis for instillai-console

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`77.64 KB` (2 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions · 2024-06-22T13:06:53Z

📦 Next.js Bundle Analysis for instillai-console

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`77.64 KB` (2 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions · 2024-06-22T13:14:10Z

📦 Next.js Bundle Analysis for instillai-console

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`77.64 KB` (2 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions · 2024-06-22T13:26:00Z

📦 Next.js Bundle Analysis for instillai-console

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`77.64 KB` (2 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions · 2024-06-22T13:30:20Z

📦 Next.js Bundle Analysis for instillai-console

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`77.64 KB` (2 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions · 2024-06-22T13:38:25Z

📦 Next.js Bundle Analysis for instillai-console

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`77.64 KB` (1 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions · 2024-06-22T13:56:49Z

📦 Next.js Bundle Analysis for instillai-console

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`77.64 KB` (2 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions · 2024-06-23T15:58:14Z

📦 Next.js Bundle Analysis for instillai-console

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`77.64 KB` (3 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

EiffelFly

@thewbuk The code you written is keeping up the code quality we want, that is pretty good! But I want to address several points with you

Don't destruct the react-query return since it hurt readability
Please put the query in package/sdk and maintain it there. You can reference how I wrote the client there, should be easy to replicate
Use Nullable everywhere if you need null data type
Reduce drastically the frequency of using setTimeout in the react lifeCycle. That is not a good pattern to escape from react lifeCycle and will cause many maintainance difficulties afterward.

Please fix these issues, and I will come back to review them further 👍

EiffelFly · 2024-07-24T06:20:55Z

apps/console/src/app/[entity]/knowledge/render.tsx

+            accessToken={accessToken.isSuccess ? accessToken.data : null}
+            enableQuery={accessToken.isSuccess}
+            router={router}
+          />


@thewbuk We don't use this kind of props to input access token and enabledQuery now. We can use the state in the useInstillStore. Please take a look at how we make it in other pages

packages/design-system/src/new-ui/Icons/SlashDivider.tsx

EiffelFly · 2024-07-24T06:25:04Z

packages/toolkit/src/lib/react-query-service/knowledge/useCreateKnowledgeBase.ts

+  if (!accessToken) {
+    return Promise.reject(new Error("accessToken not provided"));
+  }
+  const client = createInstillAxiosClient(accessToken, true);
+  const response = await client.post<{
+    knowledge_base: KnowledgeBase;
+  }>(`/namespaces/${ownerId}/knowledge-bases`, payload);
+  return response.data.knowledge_base;
+}


@thewbuk We usually maintain the query separately in the lib/vdp-sdk and now in packages/sdk

Please mimic the style in the sdk packages

You can have a arifact folder under the packages/sdk/src and put all the query in the ArtifactClient.

In this way, our user can also have a sdk about artifact to use, if they need it

PS: All the react-query-services have this issue

EiffelFly · 2024-07-24T06:27:51Z

packages/toolkit/src/lib/vdp-sdk/helper/createInstillAxiosClient.ts

+  let APIVersion = process.env.NEXT_PUBLIC_GENERAL_API_VERSION;

-  if (isModelEndpoint) {
-    APIVersion = env("NEXT_PUBLIC_MODEL_API_VERSION");
+  if (isAlphaVersion) {
+    APIVersion = process.env.NEXT_PUBLIC_MODEL_API_VERSION;


Please reference how we set up a separate APIClient using the new sdk here

console/packages/toolkit/src/lib/vdp-sdk/index.ts

Line 40 in 74ec058

export function getInstillModelAPIClient({

I believe we also need to have a getInstillArtifactAPIClient here

packages/toolkit/src/lib/vdp-sdk/knowledge/types.ts

packages/toolkit/src/view/knowledge/components/CreateKnowledgeDialog.tsx

EiffelFly · 2024-07-24T06:46:12Z

packages/toolkit/src/view/knowledge/components/CreateKnowledgeDialog.tsx

+                </Form.Item>
+              )}
+            /> */}
+            <div className="mt-8 flex justify-end gap-x-3">


@thewbuk I will encourage you to use one direction margin only, and in most case in this repo, use margin-bottom

EiffelFly · 2024-07-24T06:47:08Z

packages/toolkit/src/view/knowledge/components/EditKnowledgeDialog.tsx

+      setTimeout(() => {
+        onClose();
+        reset(initialValues);
+      }, 1000);


@thewbuk What is the reason to use setTimeout here?

EiffelFly · 2024-07-24T06:48:14Z

packages/toolkit/src/view/knowledge/components/FileDetailsOverlay.tsx

+    const { data: fileContent, isLoading: isLoadingContent } = useGetFileContent({
+        fileUid,
+        kbId,
+        accessToken,
+        enabled: isOpen,
+        ownerId,
+    });
+
+    const { data: chunks, isLoading: isLoadingChunks } = useListChunks({
+        kbId,
+        accessToken,
+        enabled: isOpen && highlightChunk,
+        ownerId,
+        fileUid,
+    });


@thewbuk Please don't destruct the react-query return, or you need to keep casting new name for each state

packages/toolkit/src/view/knowledge/components/FileDetailsOverlay.tsx

EiffelFly

@thewbuk There have multiple issues for your sdk and react-query

For the sdk, the request and response type need to be exported so you need to give them a type name
For react-query services, the query function is not right, please double check how we write the pipeline and model query fn

packages/design-system/src/new-ui/Icons/SlashDivider.tsx

EiffelFly · 2024-07-26T00:03:26Z

packages/toolkit/src/view/knowledge/tabs/KnowledgeBaseTab.tsx

+  const cloneKnowledgeBaseMutation = useMutation({
+    mutationFn: async (knowledgeBase: KnowledgeBase) => {
+      if (!accessToken || !me.data?.id) {
+        throw new Error("Not authenticated");
+      }
+
+      const client = getInstillAPIClient({ accessToken });
+      return client.vdp.knowledgeBase.createKnowledgeBase({
+        ownerId: me.data.id,
+        payload: {
+          name: `${ knowledgeBase.name } -clone`,
+          description: knowledgeBase.description,
+          tags: knowledgeBase.tags || [],
+        },
+      });
+    },
+    onSuccess: () => {
+      queryClient.invalidateQueries(['knowledgeBases', me.data?.id]);
+    },
+  });
+
+  const deleteKnowledgeBaseMutation = useMutation({
+    mutationFn: async (kbId: string) => {
+      if (!accessToken || !me.data?.id) {
+        throw new Error("Not authenticated");
+      }
+
+      const client = getInstillAPIClient({ accessToken });
+      return client.vdp.knowledgeBase.deleteKnowledgeBase({
+        ownerId: me.data.id,
+        kbId,
+      });
+    },
+    onSuccess: () => {
+      queryClient.invalidateQueries(['knowledgeBases', me.data?.id]);
+    },
+  });


@thewbuk We need to move these mutations into react-query-services

packages/sdk/src/vdp/artifact/ArtifactClient.ts

packages/toolkit/src/lib/react-query-service/knowledge/useGetFileDetails.ts

EiffelFly reviewed Jul 24, 2024

View reviewed changes

thewbuk added 16 commits July 24, 2024 16:59

feat: init structure

615d9e5

feat: frst card components and sidebar

518a236

feat sidebar and popup

65e13fd

feat styling cards

80de628

feat in card menu

0f17631

feat: start delete popup

8545140

feat styling

1e622b1

Test GPG signing

7805051

feat: styling

e884390

fix: delete dialog

0215a03

feat: edit info start

665b337

feat: edit info

6019817

fix padding in delete dropdown

2e27112

feat: deletion confirmation

74d92b2

fix timing

ad14a1c

feat: backend start

aa2d50c

thewbuk added 7 commits July 24, 2024 17:00

fix the sorting

e13c023

fix uploud multiple files

9bf1255

add file type to file details overlay

a1eda8c

use codeBlock in retrieve tab

fee4867

fix the codeblocks, tooltip

c12fc89

change the tab name

d9df2e3

update the apis to a new structure

1f37469

thewbuk force-pushed the wojciech/knowledge-base-upload-file branch from 7be54c3 to 1f37469 Compare July 24, 2024 20:15

thewbuk added 10 commits July 25, 2024 10:23

PR fixes

fe18d18

PR fixes

3da7e2c

PR fixes

9496cb4

PR fixes

6a493f7

restructure api calls

2351234

move all apis to client

3fe6006

update the api calls

fdc91c4

update the api calls

0782841

env fixes

0076bcd

update functions

4a555c0

EiffelFly reviewed Jul 29, 2024

View reviewed changes

thewbuk added 9 commits July 29, 2024 09:15

update api calls

39020d4

fix artifact client

3382502

fix artifact imports

a28cb03

fix CreditUsageFileNotification export

5a95f7e

change xports to defaults

cf16df9

fix typo and render

7c74bcf

move api client to artifact

42b107d

add artifact client to api calls

fb2a252

start fixing ts issues

83dbee4

thewbuk closed this Aug 1, 2024

EiffelFly deleted the wojciech/knowledge-base-upload-file branch August 13, 2024 11:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: MVP Knowledge #1256

feat: MVP Knowledge #1256

thewbuk commented Jun 20, 2024

github-actions bot commented Jun 20, 2024

github-actions bot commented Jun 20, 2024

github-actions bot commented Jun 20, 2024

github-actions bot commented Jun 20, 2024

github-actions bot commented Jun 20, 2024

github-actions bot commented Jun 20, 2024

github-actions bot commented Jun 22, 2024

github-actions bot commented Jun 22, 2024

github-actions bot commented Jun 22, 2024

github-actions bot commented Jun 22, 2024

github-actions bot commented Jun 22, 2024

github-actions bot commented Jun 22, 2024

github-actions bot commented Jun 23, 2024

EiffelFly left a comment •

edited

Loading

EiffelFly Jul 24, 2024

EiffelFly Jul 24, 2024

EiffelFly Jul 24, 2024

EiffelFly Jul 24, 2024

EiffelFly Jul 24, 2024

EiffelFly Jul 24, 2024

EiffelFly left a comment

EiffelFly Jul 26, 2024

feat: MVP Knowledge #1256

feat: MVP Knowledge #1256

Conversation

thewbuk commented Jun 20, 2024

github-actions bot commented Jun 20, 2024

📦 Next.js Bundle Analysis for instillai-console

⚠️ Global Bundle Size Increased

github-actions bot commented Jun 20, 2024

📦 Next.js Bundle Analysis for instillai-console

⚠️ Global Bundle Size Increased

github-actions bot commented Jun 20, 2024

📦 Next.js Bundle Analysis for instillai-console

⚠️ Global Bundle Size Increased

github-actions bot commented Jun 20, 2024

📦 Next.js Bundle Analysis for instillai-console

⚠️ Global Bundle Size Increased

github-actions bot commented Jun 20, 2024

📦 Next.js Bundle Analysis for instillai-console

⚠️ Global Bundle Size Increased

github-actions bot commented Jun 20, 2024

📦 Next.js Bundle Analysis for instillai-console

⚠️ Global Bundle Size Increased

github-actions bot commented Jun 22, 2024

📦 Next.js Bundle Analysis for instillai-console

⚠️ Global Bundle Size Increased

github-actions bot commented Jun 22, 2024

📦 Next.js Bundle Analysis for instillai-console

⚠️ Global Bundle Size Increased

github-actions bot commented Jun 22, 2024

📦 Next.js Bundle Analysis for instillai-console

⚠️ Global Bundle Size Increased

github-actions bot commented Jun 22, 2024

📦 Next.js Bundle Analysis for instillai-console

⚠️ Global Bundle Size Increased

github-actions bot commented Jun 22, 2024

📦 Next.js Bundle Analysis for instillai-console

⚠️ Global Bundle Size Increased

github-actions bot commented Jun 22, 2024

📦 Next.js Bundle Analysis for instillai-console

⚠️ Global Bundle Size Increased

github-actions bot commented Jun 23, 2024

📦 Next.js Bundle Analysis for instillai-console

⚠️ Global Bundle Size Increased

EiffelFly left a comment • edited Loading

Choose a reason for hiding this comment

EiffelFly Jul 24, 2024

Choose a reason for hiding this comment

EiffelFly Jul 24, 2024

Choose a reason for hiding this comment

EiffelFly Jul 24, 2024

Choose a reason for hiding this comment

EiffelFly Jul 24, 2024

Choose a reason for hiding this comment

EiffelFly Jul 24, 2024

Choose a reason for hiding this comment

EiffelFly Jul 24, 2024

Choose a reason for hiding this comment

EiffelFly left a comment

Choose a reason for hiding this comment

EiffelFly Jul 26, 2024

Choose a reason for hiding this comment

EiffelFly left a comment •

edited

Loading