-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: KB MVP Frontend #1328
feat: KB MVP Frontend #1328
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thewbuk I noticed that you directly use sdk client to write query string in the react-query-services, please move them into sdk package
const client = createInstillAxiosClient(accessToken, true); | ||
await client.delete(`/knowledge-bases/files?fileUid=${fileUid}`); | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thewbuk This need to be included in the sdk!
packages/toolkit/src/view/knowledge/components/CatalogFilesTab.tsx
Outdated
Show resolved
Hide resolved
packages/toolkit/src/view/knowledge/components/CatalogFilesTab.tsx
Outdated
Show resolved
Hide resolved
packages/toolkit/src/view/knowledge/components/CatalogFilesTab.tsx
Outdated
Show resolved
Hide resolved
@thewbuk The current quality of this PR is decaying too fast to a level that you might need half day full power to fix the quality issue. Here are the crucial point
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some other issues
packages/toolkit/src/lib/vdp-sdk/helper/createInstillAxiosClient.ts
Outdated
Show resolved
Hide resolved
packages/toolkit/src/lib/react-query-service/knowledge/useUpdateKnowledgeBase.ts
Outdated
Show resolved
Hide resolved
📦 Next.js Bundle Analysis for instillai-consoleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! |
📦 Next.js Bundle Analysis for instillai-consoleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! |
packages/toolkit/src/view/knowledge/components/FileTableRow.tsx
Outdated
Show resolved
Hide resolved
packages/toolkit/src/view/knowledge/components/KnowledgeBaseCard.tsx
Outdated
Show resolved
Hide resolved
NOTSTARTED: { | ||
variant: "lightNeutral", | ||
dotColor: "bg-semantic-fg-secondary", | ||
}, | ||
WAITING: { | ||
variant: "lightYellow", | ||
dotColor: "bg-semantic-warning-default", | ||
}, | ||
CONVERTING: { variant: "default", dotColor: "bg-semantic-accent-default" }, | ||
CHUNKING: { variant: "default", dotColor: "bg-semantic-accent-default" }, | ||
EMBEDDING: { variant: "default", dotColor: "bg-semantic-accent-default" }, | ||
COMPLETED: { | ||
variant: "lightGreen", | ||
dotColor: "bg-semantic-success-default", | ||
}, | ||
FAILED: { variant: "lightRed", dotColor: "bg-semantic-error-default" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thewbuk The color code is still not correct
packages/toolkit/src/view/knowledge/components/notifications/FileTooLongNotification.tsx
Outdated
Show resolved
Hide resolved
if (timeoutRef.current) { | ||
clearTimeout(timeoutRef.current); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thewbuk What is the reason you try to clear the timeout in this ref?
Because