Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: KB MVP Frontend #1328

Closed
wants to merge 613 commits into from
Closed

feat: KB MVP Frontend #1328

wants to merge 613 commits into from

Conversation

thewbuk
Copy link
Contributor

@thewbuk thewbuk commented Jul 29, 2024

Because

  • UI changes to the KB MVP to allow for more rapid deployments

Copy link
Member

@EiffelFly EiffelFly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thewbuk I noticed that you directly use sdk client to write query string in the react-query-services, please move them into sdk package

package.json Show resolved Hide resolved
Comment on lines 21 to 23
const client = createInstillAxiosClient(accessToken, true);
await client.delete(`/knowledge-bases/files?fileUid=${fileUid}`);
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thewbuk This need to be included in the sdk!

packages/toolkit/src/view/knowledge/KnowledgeBaseView.tsx Outdated Show resolved Hide resolved
@EiffelFly
Copy link
Member

@thewbuk The current quality of this PR is decaying too fast to a level that you might need half day full power to fix the quality issue. Here are the crucial point

  • We don't maintain query in the react-query-service, instead, we maintain it in the sdk packages
  • We need to export every request and response at the root level of the sdk packages. So we won't allow something like
client.get<{response: ...}>()
  • You need to constantly make your branch up-to-date
  • Every push should make sure it's buildable so others can help your local development

Copy link
Member

@EiffelFly EiffelFly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some other issues

Copy link

github-actions bot commented Aug 2, 2024

📦 Next.js Bundle Analysis for instillai-console

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 77.64 KB (-2 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

github-actions bot commented Aug 2, 2024

📦 Next.js Bundle Analysis for instillai-console

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 77.64 KB (-2 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Comment on lines +30 to +45
NOTSTARTED: {
variant: "lightNeutral",
dotColor: "bg-semantic-fg-secondary",
},
WAITING: {
variant: "lightYellow",
dotColor: "bg-semantic-warning-default",
},
CONVERTING: { variant: "default", dotColor: "bg-semantic-accent-default" },
CHUNKING: { variant: "default", dotColor: "bg-semantic-accent-default" },
EMBEDDING: { variant: "default", dotColor: "bg-semantic-accent-default" },
COMPLETED: {
variant: "lightGreen",
dotColor: "bg-semantic-success-default",
},
FAILED: { variant: "lightRed", dotColor: "bg-semantic-error-default" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thewbuk The color code is still not correct

Comment on lines 91 to 93
if (timeoutRef.current) {
clearTimeout(timeoutRef.current);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thewbuk What is the reason you try to clear the timeout in this ref?

@thewbuk thewbuk closed this Aug 2, 2024
@EiffelFly EiffelFly deleted the kb-mvp-rebase branch August 13, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants