-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deprecate markdown-to-jsx and support Latex in markdown #1623
feat: deprecate markdown-to-jsx and support Latex in markdown #1623
Conversation
📦 Next.js Bundle Analysis for instillai-consoleThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
77.65 KB (🟢 14 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
One Page Changed Size
The following page changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load |
---|---|---|
/_error |
183 B (🟢 -1 B) |
77.83 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by undefined% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
</div> | ||
<MarkdownViewer | ||
className={enableFormattedText ? "" : "hidden"} | ||
markdown={text ?? ""} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this use sanitizedHtmlText
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The MarkdownView has sanitized it, so I leave it there, but on the second though we can completely remove it in this layer
Hummm I think I can't remove it. I guess it's ok to do a duplicated sanitzed
📦 Next.js Bundle Analysis for instillai-consoleThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
77.65 KB (🟢 14 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
One Page Changed Size
The following page changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load |
---|---|---|
/_error |
183 B (🟢 -1 B) |
77.83 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by undefined% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
3da5198
to
21b946b
Compare
📦 Next.js Bundle Analysis for instillai-consoleThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
77.65 KB (🟢 14 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
One Page Changed Size
The following page changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load |
---|---|---|
/_error |
183 B (🟢 -1 B) |
77.83 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by undefined% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
🤖 I have created a release *beep* *boop* --- <details><summary>0.64.0-beta</summary> ## [0.64.0-beta](v0.63.0-beta...v0.64.0-beta) (2024-12-03) ### Features * adapt policy link and revamp setting pages ([#1629](#1629)) ([d11fab5](d11fab5)) * add feature flag for chat ([#1628](#1628)) ([7455ce4](7455ce4)) * **chat:** user can use @ to add tool suggestion in chat ([#1617](#1617)) ([d76cd51](d76cd51)) * deprecate markdown-to-jsx and support Latex in markdown ([#1623](#1623)) ([cfea04e](cfea04e)) * unify the Instill AI meeting schedule link ([#1619](#1619)) ([51e76ff](51e76ff)) ### Bug Fixes * patch high vulnerabilities deps issues ([#1631](#1631)) ([955355e](955355e)) ### Miscellaneous * **component:** add `scheduler` component ([#1637](#1637)) ([406361a](406361a)) * **component:** add icon ([#1630](#1630)) ([87174b9](87174b9)) * **component:** add icons for google-drive, perplexity-ai and leadiq ([#1627](#1627)) ([4bed7fc](4bed7fc)) </details> <details><summary>@instill-ai/design-system: 0.85.0</summary> ## [0.85.0](https://github.com/instill-ai/console/compare/@instill-ai/design-system-v0.84.0...@instill-ai/design-system-v0.85.0) (2024-12-03) ### Features * upgrade storybook deps ([#1634](#1634)) ([96bc075](96bc075)) ### Bug Fixes * further fix vulnerabilities deps ([#1632](#1632)) ([bda8462](bda8462)) * patch high vulnerabilities deps issues ([#1631](#1631)) ([955355e](955355e)) </details> <details><summary>@instill-ai/design-tokens: 0.8.1</summary> ## [0.8.1](https://github.com/instill-ai/console/compare/@instill-ai/design-tokens-v0.8.0...@instill-ai/design-tokens-v0.8.1) (2024-12-03) ### Bug Fixes * patch high vulnerabilities deps issues ([#1631](#1631)) ([955355e](955355e)) </details> <details><summary>@instill-ai/toolkit: 0.113.0</summary> ## [0.113.0](https://github.com/instill-ai/console/compare/@instill-ai/toolkit-v0.112.0...@instill-ai/toolkit-v0.113.0) (2024-12-03) ### Features * adapt policy link and revamp setting pages ([#1629](#1629)) ([d11fab5](d11fab5)) * add chat/agent related sdk and react-queries ([#1635](#1635)) ([5b6490f](5b6490f)) * add feature flag for chat ([#1628](#1628)) ([7455ce4](7455ce4)) * **chat:** user can use @ to add tool suggestion in chat ([#1617](#1617)) ([d76cd51](d76cd51)) * deprecate markdown-to-jsx and support Latex in markdown ([#1623](#1623)) ([cfea04e](cfea04e)) * deprecate the usage of integration.schemas ([#1621](#1621)) ([8bd46fc](8bd46fc)) * **integration:** support google sheet OAuth ([#1624](#1624)) ([d4c56a1](d4c56a1)) * unify the Instill AI meeting schedule link ([#1619](#1619)) ([51e76ff](51e76ff)) * update add component model UI ([#1638](#1638)) ([bfe391e](bfe391e)) ### Bug Fixes * fix cmdo event title, to make it more human readable ([#1639](#1639)) ([ec98f18](ec98f18)) * fix duplicated error message for multiple texts input of pipeline trigger form ([#1620](#1620)) ([fbbd708](fbbd708)) * fix google sheets oauth config ([#1625](#1625)) ([92734df](92734df)) * further fix vulnerabilities deps ([#1632](#1632)) ([bda8462](bda8462)) * patch high vulnerabilities deps issues ([#1631](#1631)) ([955355e](955355e)) ### Miscellaneous * **component:** add `scheduler` component ([#1637](#1637)) ([406361a](406361a)) * **component:** add icon ([#1630](#1630)) ([87174b9](87174b9)) * **component:** add icons for google-drive, perplexity-ai and leadiq ([#1627](#1627)) ([4bed7fc](4bed7fc)) * **integration:** adjust OAuth scope for google-drive component ([#1626](#1626)) ([7b341a4](7b341a4)) * **run logging:** clarify actors in Run objects ([#1622](#1622)) ([6f55bf2](6f55bf2)) * support `required` attribute in variable section ([#1636](#1636)) ([cb00594](cb00594)) </details> <details><summary>instill-sdk: 0.13.0</summary> ## [0.13.0](instill-sdk-v0.12.0...instill-sdk-v0.13.0) (2024-12-03) ### Features * add chat/agent related sdk and react-queries ([#1635](#1635)) ([5b6490f](5b6490f)) * deprecate the usage of integration.schemas ([#1621](#1621)) ([8bd46fc](8bd46fc)) ### Bug Fixes * fix cmdo event title, to make it more human readable ([#1639](#1639)) ([ec98f18](ec98f18)) * further fix vulnerabilities deps ([#1632](#1632)) ([bda8462](bda8462)) * patch high vulnerabilities deps issues ([#1631](#1631)) ([955355e](955355e)) ### Miscellaneous * **run logging:** clarify actors in Run objects ([#1622](#1622)) ([6f55bf2](6f55bf2)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Because
This commit