Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(worker): fix temporal cloud namespace init #181

Merged
merged 1 commit into from
Feb 15, 2024
Merged

fix(worker): fix temporal cloud namespace init #181

merged 1 commit into from
Feb 15, 2024

Conversation

pinglin
Copy link
Member

@pinglin pinglin commented Feb 15, 2024

Because

  • we can't programmatically list namespace in Temporal Cloud (i.e., tcld is the current only way to pass the authentication)

This commit

  • bypass the initialisation of namespace for Temporal Cloud route

@donch1989 donch1989 merged commit 1f7ec74 into main Feb 15, 2024
13 checks passed
@donch1989 donch1989 deleted the pinglin/fix-temporal-cloud-namespace branch February 15, 2024 11:33
@droplet-bot droplet-bot mentioned this pull request Feb 15, 2024
Merged
donch1989 pushed a commit that referenced this pull request Feb 16, 2024
@droplet-bot
chore(main): release 0.11.0-beta (#176)
c0f8506 
🤖 I have created a release *beep* *boop*
---


##
[0.11.0-beta](v0.10.0-beta...v0.11.0-beta)
(2024-02-16)


### Features

* delete related resources when an organization is deleted
([#180](#180))
([313d942](313d942))
* refactor AuthenticatedUser endpoints
([#175](#175))
([fbf08af](fbf08af))
* refactor user and organization profile fields
([#177](#177))
([94ff2df](94ff2df))


### Bug Fixes

* fix the membership endpoint broken after organization deleted
([#178](#178))
([59981c6](59981c6))
* **worker:** fix temporal cloud namespace init
([#181](#181))
([1f7ec74](1f7ec74))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donch1989 donch1989 Awaiting requested review from donch1989 donch1989 is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees
No one assigned
Labels
instill core
Projects
No open projects
🔮 Instill Core
Status: 👋 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pinglin @donch1989 @droplet-bot