New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(service): remove parametrized service constructor #931

Merged

jvallesm merged 1 commit into main from jvalles/chore-explicit-service-constructor

Dec 11, 2024

Collaborator

jvallesm commented Dec 11, 2024

Because

Using parameter structs for injecting dependencies is dangerous, especially when constructors are consumed by other packages / repos. Explicit parameters produce compilation errors when new dependencies are added and the client package doesn't update the constructor method call.

This commit

Transforms service.NewService to a constructor method with one argument per dependency.


          chore(service): remove parametrized service constructor

57d1f0d

jvallesm requested a review from donch1989 as a code owner

December 11, 2024 10:22

jvallesm self-assigned this

droplet-bot added the instill vdp label

jvallesm merged commit ab29d4d into main

12 checks passed

jvallesm deleted the jvalles/chore-explicit-service-constructor branch

December 11, 2024 10:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels