Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation alternative #16

Merged
merged 5 commits into from
Jan 2, 2024
Merged

Implementation alternative #16

merged 5 commits into from
Jan 2, 2024

Conversation

roodboi
Copy link
Collaborator

@roodboi roodboi commented Jan 2, 2024

This approach flips things a bit - instead of using a proxy on the one method we want to override - we use a proxy on the instructor instance and pass it through to the client if we don't have anything defined.

This way we can manage and define the full implementation and types without having to coerce things back to a valid state for the sdk

@roodboi roodboi changed the title [WIP] implementation alternative Implementation alternative Jan 2, 2024
@roodboi roodboi marked this pull request as ready for review January 2, 2024 22:57
@jxnl jxnl merged commit 3893e1a into main Jan 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants