-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validated check #23
Merged
Merged
Changes from 4 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
3dd0634
add validated check
jxnl 60a5b1a
add list of users
jxnl 556f1dc
update
jxnl d3a84d5
clean up types
jxnl 774ad02
Merge branch 'main' into test-validation
jxnl d48f510
change to user
jxnl 5e7076c
updating to tools + describe
roodboi 3d0fff6
many to tools
roodboi b2b3abf
remove describe and add debug logs
roodboi 62b6939
Update src/instructor.ts
jxnl 58f01df
Merge branch 'main' into test-validation
jxnl d491dea
update to use functions
jxnl 5d219af
Merge branch 'main' into test-validation
jxnl 8a692f4
Merge branch 'main' into test-validation
jxnl f55168c
log
jxnl 1f8426b
use 4
jxnl 10365ab
functions, debug off
jxnl 712b83c
bump model
jxnl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pulled this down and played around a bit - looks like we are really struggling to get things in uppercase
The only pass I was able to get was to switch over to using MD_JSON - my guess is likely because that mode inserts the schema in a system prompt and includes some instruction
function calls (via tools or otherwise) dont really have any system level instruction at all - maybe we should include something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the goal was that the error messages "this should be in uppercase" should prompt the llm to do that, lets try with gpt-4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should change the prompt to not just try again but to fix the erros