Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix joining room freeze #106

Merged
merged 13 commits into from
Mar 3, 2023
Merged

Fix joining room freeze #106

merged 13 commits into from
Mar 3, 2023

Conversation

rogurotus
Copy link
Contributor

@rogurotus rogurotus commented Feb 22, 2023

Synopsis

Resolves #105

If you close the last room, and then try join a new one, the join process will be eternal.
Also, if if this is done without delay, an error occurs RpcClientException.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@rogurotus rogurotus added enhancement Improvement of existing features or bugfix k::api Related to API (application interface) platform::android Specific to Android platform platform::ios Specific to iOS platform platform::web Specific to WEB platform platform::windows Specific to Windows platform platform::linux Specific to Linux platform platform::macos Specific to macOS platform labels Feb 22, 2023
@rogurotus rogurotus self-assigned this Feb 22, 2023
@rogurotus rogurotus changed the title Fix join room freeze Fix joining room freeze Feb 22, 2023
@rogurotus
Copy link
Contributor Author

rogurotus commented Feb 22, 2023

FCM:

Fix `RoomHandle.join` not resolving (#106, #105)

Additionally:
- fix build for Flutter Web
- rename `MediaDeviceInfo` to `MediaDeviceDetails`
- rename `MediaDisplayInfo` to `MediaDisplayDetails`

@rogurotus rogurotus requested a review from alexlapa February 22, 2023 16:40
@rogurotus rogurotus marked this pull request as ready for review February 22, 2023 16:40
@alexlapa alexlapa requested a review from tyranron March 3, 2023 12:41
@tyranron tyranron added the k::refactor Refactoring, technical debt elimination and other improvements of existing code base label Mar 3, 2023
@tyranron tyranron merged commit eb4d90e into master Mar 3, 2023
@tyranron tyranron deleted the fix-join-room-freeze branch March 3, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix k::api Related to API (application interface) k::refactor Refactoring, technical debt elimination and other improvements of existing code base platform::android Specific to Android platform platform::ios Specific to iOS platform platform::linux Specific to Linux platform platform::macos Specific to macOS platform platform::web Specific to WEB platform platform::windows Specific to Windows platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RoomHandle.join issues when using the same Jason instance
3 participants