Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration with flutter_webrtc #12

Merged
merged 100 commits into from
Dec 24, 2021
Merged

Integration with flutter_webrtc #12

merged 100 commits into from
Dec 24, 2021

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Oct 29, 2021 •
edited
Loading

Synopsis

Это PR из цикла задач по интеграции Jason'а в Flutter Android. В рамках этой задачи, были добавлены оставшиеся биндинги для flutter_webrtc. В некоторых местах используются заглушки, это связано с тем, что не весь нужный функционал реализован в flutter_webrtc на данный момент. Эти заглушки будут заменены на реальные вызовы flutter_webrtc функций после его переработки. На этой ветке базово работают звонки на Android'е.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed
    • flutter-webrtc dependency switched back to master branch

evdokimovs and others added 30 commits October 6, 2021 19:33
@evdokimovs
Add platform utils
76f0b85
@evdokimovs
Reread, cleanup
ca6abd7
@alexlapa
Merge branch 'master' into add-platform-utils
75129b6
@evdokimovs
Impl
578b01f
@alexlapa
corrections
5a5e3be
@evdokimovs
Implement CallbackListener with DartValue and add tests for it
d338997
@evdokimovs
Cleanup
005d0a5
@evdokimovs
Migrate DartFutureResolver to DartValue approach
16836b8
@evdokimovs
Impl FallibleDartFutureResolver
b57fc6d
@evdokimovs
Add docs
0f76280
@evdokimovs
Fix lints
1f068f4
@evdokimovs
Merge branch 'master' into add-platform-utils
eda516d
@evdokimovs
Fix merge
c6b339b
@evdokimovs
Reread
89bd6a8
@evdokimovs
Fix FallibleFutureResolver
aabad5d
@evdokimovs
Arg cleaning and refactoring
448dfee
@evdokimovs
Merge branch 'master' into add-basic-dart-bindings
c7d191e
@evdokimovs
Merge branch 'add-platform-utils' into add-basic-dart-bindings
33790fb 
# Conflicts:
#	src/platform/dart/utils/mod.rs
@alexlapa
Merge branch 'master' into add-platform-utils
1926754
@evdokimovs
Adapt to the new DartValue approach
415200e
@evdokimovs
Add convertation of DartValue to DartHandle
405ca8d
@evdokimovs
Refactor working with primitives with DartValue
e8fada6
@alexlapa
corrections
378878c
@evdokimovs
Add Dart side platform bindings
0135bed
@evdokimovs
Refactor
007664f
@alexlapa
corrections
c47fe9c
@alexlapa
corrections
848dd3a
@evdokimovs
Fix bugs
9859ab7
@evdokimovs
Remove old error
2c15bf1
@evdokimovs
Merge remote-tracking branch 'origin/add-platform-utils' into add-pla…
c1a9d36 
…tform-utils

# Conflicts:
#	src/platform/dart/utils/dart_future.rs
@evdokimovs
Copy link
Contributor Author

@alexlapa ,

Изменения по удалению Transceiver::is_stopped пришлось откатить, поскольку стейт Stopped еще не завезли в web_sys::TransceiverDirection.

@evdokimovs evdokimovs requested a review from alexlapa December 20, 2021 11:32
alexlapa
alexlapa approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@alexlapa alexlapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evdokimovs ,

От меня LGTM, перепроверьте что все работает, пожалуйста, и, если все ок - передавайте tyranron'у.

@evdokimovs evdokimovs requested a review from tyranron December 21, 2021 18:03
tyranron
tyranron requested changes Dec 22, 2021
View reviewed changes
src/platform/dart/utils/map.rs Outdated Show resolved Hide resolved
src/platform/dart/media_devices.rs Show resolved Hide resolved
src/platform/dart/media_devices.rs Show resolved Hide resolved
@evdokimovs evdokimovs requested a review from alexlapa December 22, 2021 16:31
alexlapa
alexlapa reviewed Dec 22, 2021
View reviewed changes
flutter/lib/src/native/platform/transport.dart Outdated

/// Wrapper around [WebSocket] which stores WS messages if no one
/// currently listens to them and provides it to the first subscriber.
class BufferedWebSocket {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evdokimovs ,

В смысле между созданием сокета и моментмо как раст на него подпишется успевают дойти сообщения?

Может сразу в connect прокидывать onMessage и onClose каллбеки?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexlapa ,

И правда перемудрил. В нашем случае это и правда более удачный вариант. Запушил эти изменения.

@alexlapa alexlapa self-requested a review December 23, 2021 10:37
@alexlapa alexlapa requested a review from tyranron December 23, 2021 10:55
@tyranron tyranron changed the title Draft: Integration with flutter_webrtc Integration with flutter_webrtc Dec 24, 2021
@evdokimovs evdokimovs merged commit 1e084b9 into master Dec 24, 2021
@evdokimovs evdokimovs deleted the flutter-webrtc-integration branch December 24, 2021 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

@alexlapa alexlapa alexlapa approved these changes

Assignees

@evdokimovs evdokimovs

Labels
feature New feature or request k::api Related to API (application interface) k::design Related to overall design and/or architecture k::refactor Refactoring, technical debt elimination and other improvements of existing code base platform::android Specific to Android platform platform::ios Specific to iOS platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evdokimovs @tyranron @alexlapa