Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to crates.io version of wasm-bindgen #155

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Switch to crates.io version of wasm-bindgen #155

merged 3 commits into from
Mar 6, 2024

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Mar 6, 2024 •
edited by tyranron
Loading

Related to #151

Synopsis

For implementation of ICE candidates error sending (#151) it was required to make changes in web-sys and because of it medea-jason started using git version of wasm-bindgen-related dependencies.

Now required feature was released in wasm-bindgen v0.2.92, so we can switch back to crates.io version of crate.

Solution

Switch back to crates.io version of wasm-bindgen-related dependencies.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
    • Has assignee
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@evdokimovs evdokimovs added enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base platform::web Specific to WEB platform k::dependencies Pull requests that update a dependency file labels Mar 6, 2024
@evdokimovs evdokimovs self-assigned this Mar 6, 2024
@evdokimovs
Copy link
Contributor Author

evdokimovs commented Mar 6, 2024 •
edited by tyranron
Loading

FCM

Upgrade `web-sys` crate to 0.3.68 version (#155)

@evdokimovs evdokimovs marked this pull request as ready for review March 6, 2024 12:16
@evdokimovs evdokimovs requested a review from tyranron March 6, 2024 12:16
@tyranron tyranron removed the k::refactor Refactoring, technical debt elimination and other improvements of existing code base label Mar 6, 2024
@tyranron tyranron enabled auto-merge (squash) March 6, 2024 15:36
@tyranron tyranron merged commit b7fa64a into master Mar 6, 2024
51 checks passed
@tyranron tyranron deleted the use-crates-io-wasm-bindgen branch March 6, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@evdokimovs evdokimovs

Labels
enhancement Improvement of existing features or bugfix k::dependencies Pull requests that update a dependency file platform::web Specific to WEB platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evdokimovs @tyranron