Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edition upgrade #16

Merged
merged 30 commits into from
Jan 17, 2022
Merged

Edition upgrade #16

merged 30 commits into from
Jan 17, 2022

Conversation

tyranron
Copy link
Member

Upgrades project to 2021 Rust edition.

Upgrades all the dependencies.

Hardens lints.

@tyranron tyranron added enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base k::toolchain Related to project toolchain labels Nov 23, 2021
@tyranron tyranron self-assigned this Nov 23, 2021
@tyranron
Copy link
Member Author

tyranron commented Jan 13, 2022

@evdokimovs would you be so kind to elaborate on those 2 issues in medea-jason tests?

I'm going to merge this at the end of the week once 1.58 Rust is released.

@evdokimovs
Copy link
Contributor

@tyranron ,

Проблема была в обновлении крейта backoff до версии 0.4. Судя по всему, из-за изменений связанных с Error::Transient поломалось повторение попыток реконнекта. Немного поковырялся в диффе между версиями backoffа, но очевидных мест бага не нашел.

Предлагаю пока откатиться до backoff v0.3, и после рефакторинга flutter_webrtc Android пофиксить эту багу в крейте backoff (если ее к тому времени, еще не пофиксят).

cc @alexlapa

@tyranron
Copy link
Member Author

@evdokimovs backoff crate has tests passing and it's widely used. No similar issue has been reported there. I think that trouble is not in the backoff crate, but in our code, appeared, due to fixes in backoff.

I wonder whether ihrwein/backoff#42 is the reason.

@evdokimovs
Copy link
Contributor

@tyranron ,

@evdokimovs backoff crate has tests passing and it's widely used. No similar issue has been reported there. I think that trouble is not in the backoff crate, but in our code, appeared, due to fixes in backoff.

I wonder whether ihrwein/backoff#42 is the reason.

Да, Вы правы. Тест посыпался из-за этого фикса. По-сути мы своими тестами случайно закрепили некорректное поведение.

Тест пофиксил, версию backoff откатил.

@tyranron tyranron marked this pull request as ready for review January 17, 2022 15:46
@tyranron tyranron merged commit ad921e3 into master Jan 17, 2022
@tyranron tyranron deleted the edition-upgrade branch January 17, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base k::toolchain Related to project toolchain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants