Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LocalMediaTrack.on_audio_level_changed() callback #167

Merged
merged 21 commits into from
May 29, 2024

Conversation

rogurotus
Copy link
Contributor

@rogurotus rogurotus commented May 2, 2024

Synopsis

Adds an API for tracking the audio level of local tracks

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
    • Has assignee
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@rogurotus rogurotus added enhancement Improvement of existing features or bugfix k::api Related to API (application interface) labels May 2, 2024
@rogurotus rogurotus self-assigned this May 2, 2024
@rogurotus
Copy link
Contributor Author

rogurotus commented May 2, 2024

FCM

Add `LocalMediaTrack.on_audio_level_changed()` callback (#167)

@rogurotus rogurotus marked this pull request as ready for review May 2, 2024 11:28
@rogurotus rogurotus requested a review from evdokimovs May 2, 2024 11:28
@evdokimovs evdokimovs assigned evdokimovs and unassigned rogurotus May 15, 2024
@evdokimovs evdokimovs removed their request for review May 15, 2024 10:53
@evdokimovs evdokimovs added feature New feature or request and removed enhancement Improvement of existing features or bugfix labels May 28, 2024
@evdokimovs evdokimovs changed the title Add on audio level callback of local audio track Add LocalMediaTrack.on_audio_level_changed() callback May 28, 2024
@evdokimovs evdokimovs requested a review from tyranron May 28, 2024 16:44
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evdokimovs we have this no-op on Web. Is it intended to be implemented in a separate PR or impossible at all?

@evdokimovs
Copy link
Contributor

evdokimovs commented May 29, 2024

@tyranron ,

@evdokimovs we have this no-op on Web. Is it intended to be implemented in a separate PR or impossible at all?

It is possible to implement this feature using Web Audio API. We can do it later, but I think that it's a low priority feature at this moment.

@tyranron
Copy link
Member

@evdokimovs regarding the priority - OK, but add it backlog, please, to not forget about it.

@tyranron tyranron merged commit 7917ba8 into master May 29, 2024
51 checks passed
@tyranron tyranron deleted the local-on-audio-level branch May 29, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request k::api Related to API (application interface)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants