Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RemoteMediaTrack.onMediaDirectionChanged() (#42) #46

Merged
merged 31 commits into from
Apr 27, 2022
Merged

Add RemoteMediaTrack.onMediaDirectionChanged() (#42) #46

merged 31 commits into from
Apr 27, 2022

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Apr 13, 2022 •
edited by tyranron
Loading

Resolves #42

Synopsis

This PR adds RemoteMediaTrack.onMediaDirectionChanged callback which will be called when participant disables media sending or media receiving disabled locally. Based on this callback, user can determine on which sides RemoteMediaTrack is disabled.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs added feature New feature or request k::api Related to API (application interface) labels Apr 13, 2022
@evdokimovs evdokimovs self-assigned this Apr 13, 2022
evdokimovs and others added 23 commits April 14, 2022 12:55
@evdokimovs
Fix MediaDirection update
329ab1c
@evdokimovs
Merge branch 'master' into add-media-exchange-direction
fa0dbad 
# Conflicts:
#	flutter/android/src/main/jniLibs/arm64-v8a/libmedea_jason.so
#	flutter/android/src/main/jniLibs/armeabi-v7a/libmedea_jason.so
#	flutter/android/src/main/jniLibs/x86/libmedea_jason.so
#	flutter/android/src/main/jniLibs/x86_64/libmedea_jason.so
#	flutter/assets/pkg/medea_jason.js
#	flutter/assets/pkg/medea_jason_bg.wasm
@evdokimovs
Rebuild all
924174f
@alexlapa
try refactor, maybe revert
343bbcc
@evdokimovs
WIP
ca493d6
@evdokimovs
Minor fixes, rebuild
79bdcfc
@evdokimovs
Just testing
8a0574d
@evdokimovs
Minor
641254b
@evdokimovs
Minor
f037c12
@evdokimovs
Minor E2E fix
3f61303
@evdokimovs
Minor E2E fix
3e20693
@evdokimovs
Minor
2e509c5
@evdokimovs
Minor
6070776
@evdokimovs
Minor upd
33fa1dc
@evdokimovs
Minor refactor
f77abaa
@evdokimovs
Merge branch 'master' into add-media-exchange-direction
f7acffc 
# Conflicts:
#	flutter/assets/pkg/medea_jason.js
#	flutter/assets/pkg/medea_jason_bg.wasm
#	flutter/example/pubspec.lock
#	flutter/lib/src/interface/remote_media_track.dart
#	flutter/lib/src/native/remote_media_track.dart
#	flutter/lib/src/web/remote_media_track.dart
@evdokimovs
Rebuild all
1ba721c
@evdokimovs
Fix flutter_webrtc
22edfa5
@evdokimovs
Fix unit tests
fcf1fa3
@evdokimovs
Minor fix unit
81c2815
@alexlapa
corrections
3ae5abf
@alexlapa
corrections
9fc1d66
@alexlapa
corrections
275fce3
@alexlapa alexlapa self-requested a review April 26, 2022 11:01
@alexlapa
Copy link
Contributor

FCM:

Add `RemoteMediaTrack.onMediaDirectionChanged()` callback (#46)

@alexlapa alexlapa marked this pull request as ready for review April 26, 2022 11:07
alexlapa
alexlapa reviewed Apr 26, 2022
View reviewed changes
.github/workflows/ci.yml
@@ -12,7 +12,7 @@ concurrency:
cancel-in-progress: true

env:
MEDEA_BRANCH: edge # for E2E tests only
MEDEA_BRANCH: add-media-exchange-direction # for E2E tests only
Copy link
Contributor

@alexlapa alexlapa Apr 26, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyranron ,

Это я в следующем PR'е ревертну, после слива соответсвующей задачи в instrumentisto/medea.

@alexlapa alexlapa requested a review from tyranron April 26, 2022 11:41
tyranron
tyranron approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FCM

Add `RemoteMediaTrack.on_media_direction_changed()` callback (#46, #42)

- remove `RemoteMediaTrack.on_enabled()` and `RemoteMediaTrack.on_disabled()` callbacks
- refactor Client API proto to use `MediaDirection`

@tyranron tyranron merged commit 1220023 into master Apr 27, 2022
@tyranron tyranron deleted the add-media-exchange-direction branch April 27, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

@alexlapa alexlapa alexlapa approved these changes

Assignees

@evdokimovs evdokimovs

Labels
feature New feature or request k::api Related to API (application interface)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add RemoteMediaTrack.onTransceiverDirectionChange()
4 participants
@evdokimovs @alexlapa @tyranron @logist322