Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic Dart platform bindings for Rust #8

Merged
merged 29 commits into from
Oct 26, 2021
Merged

Add basic Dart platform bindings for Rust #8

merged 29 commits into from
Oct 26, 2021

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Oct 6, 2021 •
edited
Loading

Synopsis

Это PR из цикла задач по интеграции Jason'а в Flutter Android. В рамках этой задачи, были реализованы основные биндинги используемые для взаимодействия с Dart'ом.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs added feature New feature or request k::api Related to API (application interface) k::design Related to overall design and/or architecture platform::android Specific to Android platform platform::ios Specific to iOS platform labels Oct 6, 2021
@evdokimovs evdokimovs self-assigned this Oct 6, 2021
@evdokimovs evdokimovs changed the title Draft: Add platform utils bindings Draft: Add basic Dart platform bindings Oct 6, 2021
@evdokimovs
Copy link
Contributor Author

evdokimovs commented Oct 7, 2021 •
edited by tyranron
Loading

FCM

Add basic Dart platform bindings for Rust (#8)

@evdokimovs evdokimovs marked this pull request as ready for review October 7, 2021 10:44
@evdokimovs evdokimovs requested a review from alexlapa October 7, 2021 10:54
alexlapa
alexlapa requested changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@alexlapa alexlapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed, added todos.

@evdokimovs evdokimovs requested a review from alexlapa October 19, 2021 13:53
@alexlapa alexlapa requested a review from tyranron October 25, 2021 11:45
@tyranron tyranron changed the title Draft: Add basic Dart platform bindings Add basic Dart platform bindings Oct 26, 2021
@evdokimovs evdokimovs changed the title Add basic Dart platform bindings Add basic Dart platform bindings for Rust Oct 26, 2021
@evdokimovs evdokimovs merged commit 2ffa445 into master Oct 26, 2021
@evdokimovs evdokimovs deleted the add-platform-utils branch October 26, 2021 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

@alexlapa alexlapa alexlapa approved these changes

Assignees

@evdokimovs evdokimovs

Labels
feature New feature or request k::api Related to API (application interface) k::design Related to overall design and/or architecture platform::android Specific to Android platform platform::ios Specific to iOS platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evdokimovs @tyranron @alexlapa