fix: Do not ignore file deletion errors #2553
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deleting a file errors (such as "409 Could not delete file: Changes must be made through a pull request") should not be silently ignored leaving the file undeleted from the repo but deleted from the state
|
I've just found a similar change which has not been merged yet #2465 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resource:
github_repository_fileWhen deleting a file errors (such as
409 Could not delete file: Changes must be made through a pull request) should not be silently ignored leaving the file undeleted from the repo but deleted from the stateResolves #2464
Before the change?
Resource github_repository_file ignores any errors when deleting files which results in inconsistencies
After the change?
Resource github_repository_file stops on errors if any when deleting files
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!