Skip to content

Validate autolink prefix#3245

Open
Jwels1 wants to merge 3 commits intointegrations:mainfrom
Jwels1:validate-autolink-prefix
Open

Validate autolink prefix#3245
Jwels1 wants to merge 3 commits intointegrations:mainfrom
Jwels1:validate-autolink-prefix

Conversation

@Jwels1
Copy link

@Jwels1 Jwels1 commented Mar 1, 2026

Resolves #3176


Before the change?

422 Validation Failed [{Resource:KeyLink Field:key_prefix Code:custom Message:key_prefix must not end with a number} {Resource:KeyLink Field:key_prefix Code:custom Message:key_prefix must only contain letters, numbers, or .-_+=:/#}]

After the change?

  • Terraform plan will throw an error during plan due to a failure to validate key_prefix

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@github-actions
Copy link

github-actions bot commented Mar 1, 2026

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

Copy link
Collaborator

@deiga deiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! It's a nice Quality of Life improvement ☺️

Left a minor comment

Co-authored-by: Timo Sand <timo.sand@iki.fi>
@Jwels1
Copy link
Author

Jwels1 commented Mar 3, 2026

@deiga good catch, you're right that it does work just the same. I applied the suggestion.

@Jwels1
Copy link
Author

Jwels1 commented Mar 11, 2026

@deiga or @MarkVaughn Do you guys. have someone else that can approve the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: autolink allows numbers during plan, but fails during apply

3 participants