Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no_std compatiblity #1

Merged
merged 50 commits into from
Apr 20, 2023
Merged

Add no_std compatiblity #1

merged 50 commits into from
Apr 20, 2023

Conversation

OverOrion
Copy link

This PR adds no_std compatibility to the nostr crate only, other crates were not modified.

The PR also contains a dummy no_std binary crate which served as test crate for making sure the port was indeed no_std compatible.

OverOrion and others added 30 commits March 23, 2023 13:30
@OverOrion
std feature
6bf82c5
@OverOrion
use thiserror-core with alloc feature
ef565b3
@OverOrion
time: make it no_std compatible with a setter as there is no now() me…
efca948 
…thod in the no_std world :(
@OverOrion
Revert "time: make it no_std compatible with a setter as there is no …
77ef1c8 
…now() method in the no_std world :("

This reverts commit efca948.
@OverOrion
time: make it no_std compatible with a setter as there is no now() me…
8f5e8a5 
…thod in the no_std world :(
@OverOrion
nostr: make nostr crate no_std compatible
a8caa73 
This reverts commit 77ef1c8.
@OverOrion
nostr: no_std support
caa1122
@OverOrion
fixup! nostr: no_std support
891743e
@OverOrion
nostr: port nip26
a3d9409
@OverOrion
fixup! nostr: no_std support
134314f
@OverOrion
fixup! nostr: no_std support
f1d1f33
@OverOrion
nostr: port nip13
3392a30
@OverOrion
nostr: port nip65
1a19c65
@OverOrion
fixup! nostr: no_std support
c34955c
@OverOrion
nostr: outsourcing time for no_std
584655f
@OverOrion
halp
43d7103
@OverOrion
halp2
1f97ae8
@OverOrion
compiling
542d7af
@OverOrion
compiling, after cleanup
ddb09fa
@OverOrion
add docs comments
92ee7ed
@OverOrion
nostr: make sure dependencies are no_std compatible
3bc4336
@OverOrion
backup
68f93da
@OverOrion
no_std: use patched secp256k1
3951356
@OverOrion
no_std: switch back to upstream rust-url
91e57b6
@OverOrion
compiling
7db1091
@OverOrion
working dir copy with Chris
358b2d5
@OverOrion
ensure_no_std
415a8b0
@clangenb
accept that other crates don't implement error
cb0e12a
@clangenb
no-std compiles
a33b084
@clangenb
add no std test crate
62ffc26
@OverOrion OverOrion mentioned this pull request Apr 18, 2023
Closed
@OverOrion OverOrion linked an issue Apr 18, 2023 that may be closed by this pull request
make nostr crate no_std for use in enclave encointer/personhood-oracle#1
Closed
coax1d
coax1d reviewed Apr 20, 2023
View reviewed changes
Copy link

@coax1d coax1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just few small comments. Alot in this one.

crates/ensure_no_std/Cargo.toml Outdated Show resolved Hide resolved
crates/ensure_no_std/src/main.rs Outdated Show resolved Hide resolved
crates/ensure_no_std/src/main.rs Show resolved Hide resolved
crates/nostr/Cargo.toml Outdated Show resolved Hide resolved
@OverOrion OverOrion requested a review from coax1d April 20, 2023 08:39
coax1d
coax1d approved these changes Apr 20, 2023
View reviewed changes
Copy link

@coax1d coax1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OverOrion OverOrion merged commit d4aa762 into integritee-network:sgx-no-std Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coax1d coax1d coax1d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make nostr crate no_std for use in enclave
3 participants
@OverOrion @coax1d @clangenb