-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test commit #20
test commit #20
Conversation
Thank you @alex-byteport. The only thing I see here is changes in formatting. I think we need to find an agreement on this because I don't want to see formatting changes in PRs that do other stuff too. reviewing is too painful if 90% is formatting changes. I can apply your formatting style in my IDE as well, but I certainly only want to do this change once May I ask you to always use the PR description field to briefly describe what this PR changes? |
I introduced linting and autoformatting in #21. Please follow these formatting rules from now onwards. you can just run |
If this PR has more than just code formatting, please resolve conflicts and autoformat. otherwise, please close. |
fixed functionality and took your example to improve the design in other places too @alex-byteport. Thanks for the nice inputs! Problems with this PR were:
|
No description provided.