This repository was archived by the owner on Sep 16, 2021. It is now read-only.
Search connectors in DLEYNA_CONNECTOR_PATH#50
Open
jtojnar wants to merge 1 commit intointel:masterfrom
Open
Conversation
Previously, the connectors would only be looked for in a single directory, specified during compilation. This patch allows to traverse a list of directories provided by an environment variable.
8 tasks
|
From what I can see even if the environment variable DLYNA_CONNECTOR_PATH is not set the code still uses the original behavior so I don't see a problem with this commit. |
|
Is there anything blocking this? |
|
@bb010g Thanks for bringing this to my attention. I don't know if anything is blocking this change. I will contact the project maintainers in person and see if I can get some feed back. It looks to me that this commit may have just been forgotten about. |
10 tasks
phako
reviewed
Dec 2, 2020
| connector_path_list = g_strsplit (connector_path, G_SEARCHPATH_SEPARATOR_S, 0); | ||
|
|
||
| for (i = 0; connector_path_list[i]; i++) { | ||
| path = g_strdup_printf("%s/%s%s.so", connector_path_list[i], |
There was a problem hiding this comment.
For maximum compatibility you could probably use g_module_build_path here but that's minor and would also probably need a change for DLEYNA_CONNECTOR_LIB_PATTERN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the connectors would only be looked for in a single directory, specified during compilation. This patch allows to traverse a list of directories provided by an environment variable.
We need it for NixOS where packages are installed into read-only tree so the different connectors cannot be placed into a single directory.